kleopatra999 / webm

Automatically exported from code.google.com/p/webm
0 stars 0 forks source link

vpxenc --test-decode=warn crashes with vp8 #841

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
v1.3.0-3839-g1043474

$ ./vpxenc --codec=vp8 --test-decode=warn \
  --width=352 --height=288 \
  --limit=10 --ivf \
  --output=/tmp/vp8.ivf \
  hantro_collage_w352h288.yuv

bisects to:

e956c00762d9a7955be15ff9ae892227cf3429b4 is the first bad commit
commit e956c00762d9a7955be15ff9ae892227cf3429b4
Author: Johann <johannkoenig@google.com>
Date:   Wed Jul 16 02:30:21 2014 -0700

    Set and use uv_crop_[width|height]

    Ensure consistent border extension by rounding uv_crop_* at image
    creation time. Where it was rounded problems could arise with the right
    and bottom extensions.
    When padding = 32, y_width = 64, and y_crop_width = 63:
     (padding + width - crop_width + 1) / 2
     32 + 64 - 63 + 1 should equal 32 *but*
     32 + 1 + 1 equals 34 giving a right buffer of 17 instead of 16.
    By calculating uv_crop_* earlier we round up at the appropriate time and
    for the same values:
     (y_crop_width + 1) / 2
     63 + 1 / 2
     64
     (padding / 2) + uv_width - uv_crop_width
     16 + 16 - 16
     16

    Change-Id: If866cd1b63444771440edb1432280ac83875969b

:040000 040000 57c35130f3f85785199e7797d471d095eba1ecaa 
c2ad7f421bf9a9d98239b65df48bdb1bb89ee5f3 M      vpx_scale

Original issue reported on code.google.com by jz...@google.com on 15 Aug 2014 at 3:08

GoogleCodeExporter commented 9 years ago
Missed image2yuvconfig function. For some reason I thought that was related to 
error handling or something.

https://gerrit.chromium.org/gerrit/71214

Original comment by johannko...@google.com on 15 Aug 2014 at 6:03

GoogleCodeExporter commented 9 years ago
fix is submitted

Original comment by ya...@google.com on 3 Oct 2014 at 7:24