search

kleopatra999 / webm

Automatically exported from code.google.com/p/webm
0 stars 0 forks source link

Yasm 1.3.0 support on visual studio build on windows for Win32 and x64 #843

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
There is a slight change in 1.3.0 YASM's naming of platforms. Libvpx build 
system need to be updated to be compatible for these changes: 
Yasm-1.2 -> Yasm-1.3
 Win32   ->  win32
 x64     ->  win64

Original issue reported on code.google.com by ya...@google.com on 19 Aug 2014 at 11:44

GoogleCodeExporter commented 9 years ago

Original comment by ya...@google.com on 22 Aug 2014 at 6:00

GoogleCodeExporter commented 9 years ago 
x64/win64 should be synonyms since at least 0.8.0; Johann took a patch [1] 
which went from win${bits}->x64 in configure, but it looks like bits being set 
might have been the problem, not the format name specifically.
The command is generated separately with VS (gen_msvs_proj.sh, 
gen_msvs_vcproj.sh), using the platform name thus the 'Win32'. I haven't tested 
1.3.0, but in that case I guess it became case-sensitive.

[1] https://gerrit.chromium.org/gerrit/#/c/11263

Original comment by jz...@google.com on 22 Aug 2014 at 8:04

GoogleCodeExporter commented 9 years ago 
I have tried yasm 1.3.0 64 bit windows binary, got:
yasm: FATAL: unrecognized object format `x64'
In visual studio build. 
Replacing the yasm binary with 1.2.0 release, everything works fine.

Original comment by ya...@google.com on 22 Aug 2014 at 8:37

GoogleCodeExporter commented 9 years ago 
This was merged some time ago:
c5795d8 gen_msvs_(vcx)proj.sh: set yasm format explicitly
https://gerrit.chromium.org/gerrit/#/c/71328/

Original comment by jz...@google.com on 22 Sep 2014 at 9:42