valgrind error in rd_pick_partition

[GoogleCodeExporter]

Bisecting shows 
http://git.chromium.org/gitweb/?p=webm/libvpx.git;a=commit;h=bb260d90 as 
responsible.

The test in question is VP9/ActiveMapTest.Test/4. 

http://build.webmproject.org/jenkins/job/libvpx%20unit%20tests%20(valgrind-2)/ar
ch=x86-linux-gcc,filter=-*VP8*%3A*Large.*/406/valgrindResult/pid=4991/

Original issue reported on code.google.com by aconve...@google.com on 8 Oct 2014 at 7:07

[GoogleCodeExporter]

Original comment by jingn...@google.com on 8 Oct 2014 at 10:11

• Changed state: Started

[GoogleCodeExporter]

fix

https://gerrit.chromium.org/gerrit/#/c/71775/

Original comment by jingn...@google.com on 8 Oct 2014 at 10:12

[GoogleCodeExporter]

fix is merged. 

Original comment by ya...@google.com on 9 Oct 2014 at 10:15

• Changed state: Fixed

[GoogleCodeExporter]

This test still fails at speed 1. Reopening. 

$ /usr/bin/valgrind ./test_libvpx --gtest_filter=VP9/ActiveMapTest.Test/1
==2981== Memcheck, a memory error detector
==2981== Copyright (C) 2002-2013, and GNU GPL'd, by Julian Seward et al.
==2981== Using Valgrind-3.10.0.SVN and LibVEX; rerun with -h for copyright info
==2981== Command: ./test_libvpx --gtest_filter=VP9/ActiveMapTest.Test/1
==2981== 
Note: Google Test filter = VP9/ActiveMapTest.Test/1-:AVX2/*
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from VP9/ActiveMapTest
[ RUN      ] VP9/ActiveMapTest.Test/1
==2981== Conditional jump or move depends on uninitialised value(s)
==2981==    at 0x6C52F6: rd_pick_partition (vp9_encodeframe.c:2279)
==2981==    by 0x6C366D: rd_pick_partition (vp9_encodeframe.c:2369)
==2981==    by 0x6C366D: rd_pick_partition (vp9_encodeframe.c:2369)
==2981==    by 0x6C366D: rd_pick_partition (vp9_encodeframe.c:2369)
==2981==    by 0x6CA9DF: encode_frame_internal (vp9_encodeframe.c:2625)
==2981==    by 0x6CCD92: vp9_encode_frame (vp9_encodeframe.c:3561)
==2981==    by 0x604E8F: encode_frame_to_data_rate (vp9_encoder.c:2552)
==2981==    by 0x607EE4: vp9_get_compressed_data (vp9_encoder.c:3224)
==2981==    by 0x5CAD19: encoder_encode (vp9_cx_iface.c:952)
==2981==    by 0x55307D: vpx_codec_encode (vpx_encoder.c:223)
==2981==    by 0x499CB9: 
libvpx_test::Encoder::EncodeFrameInternal(libvpx_test::VideoSource const&, 
unsigned long) (encode_test_driver.cc:62)
==2981==    by 0x49AAC8: 
libvpx_test::EncoderTest::RunLoop(libvpx_test::VideoSource*) 
(encode_test_driver.cc:22)
==2981== 
[       OK ] VP9/ActiveMapTest.Test/1 (23458 ms)
[----------] 1 test from VP9/ActiveMapTest (23463 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (23498 ms total)
[  PASSED  ] 1 test.
==2981== 
==2981== HEAP SUMMARY:
==2981==     in use at exit: 0 bytes in 0 blocks
==2981==   total heap usage: 77,231 allocs, 77,231 frees, 22,338,914 bytes 
allocated
==2981== 
==2981== All heap blocks were freed -- no leaks are possible
==2981== 
==2981== For counts of detected and suppressed errors, rerun with: -v
==2981== Use --track-origins=yes to see where uninitialised values come from
==2981== ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 0 from 0)

Original comment by aconve...@google.com on 10 Oct 2014 at 6:52

• Changed state: Assigned

[GoogleCodeExporter]

fix

https://gerrit.chromium.org/gerrit/#/c/71807/

Original comment by jingn...@google.com on 12 Oct 2014 at 5:38

[GoogleCodeExporter]

Original comment by aconve...@google.com on 13 Oct 2014 at 5:09

• Changed state: Verified