Unchecking 'omit' has multiple problems

[klequis]

1. Open tx with omit rule
2. Uncheck omit
   • Expected: default actions should show in UI
   • Actual: default actions do not show (the area has not content)
3. Save
   • Expected: Saving of default actions should not be possible as it would create a rule that results in no change to data.
   • Actual: Rule is saved to db with an empty actions array

[klequis]

While it is true that you should not be able to save default actions as they do nothing, it is possible that criteria were changed before actions were changed before actions were reset to default.

Therefore:

• criteria changed?
• actions changed?

I could take an existing rule, change the criteria and then save. So there seems to be some interaction between new vs existing rule && criteria vs actions change that needs to be fleshed out.

[klequis]

New Rule

• Change criteria -> not dirty
• Change actions -> dirty

Existing Rule

• Change criteria -> dirty
• Change actions -> dirty

New Rule

• Click omit -> default actions -> bad case bec this rule now does nothing (it just rewrites the existing data)
  • should it go to an not dirty case and be deleted if not changed

Needs more thought but one possibility is:

• Open omit rule
• Uncheck omit
• Becomes new tmp rule
• The original rule is marked for deletion
• User is given an info box

Another thought is

• Opening an omit rule looks very different than non-omit rules
• It makes clear to the user that the only thing that can be done is to delete the rule and start over
  • Do you want to a) delete omit rule and create a new one || b) delete the omit rule and return to tx list || c) cancel / do nothing
  • So the user is given three choices. The transactions effected are show below.
• So user clicks delete omit rule (or something like that) and a new rule is created
• It is made clear to the user that they must make changes to the rule to save it or cancel if they do not

[klequis]

• User clicks on transaction that has an omit rule.
• User unchecks Omit
• Criteria are unchanged
• Default actions reappear
  • isDirty === false

Notes:

isDirty === false

Seems odd but at this point if rule were to be saved

1. it would remove the omit rule from the db
2. but it will become a rule that effect no change on the data. Therefore why save it.

From a users perspective this is confusing. Could put a notice that user needs to 1) delete the rule or 2) make a change to the rule and save it.

Going to leave it as is for now.

[klequis]

closing