search

kleros / curate-v2

Curate V2
https://curate-v2.netlify.app/
1 stars 3 forks source link

Feat/removal challenge justification display #42

Closed Harman-singh-waraich closed 5 months ago

Harman-singh-waraich commented 5 months ago

PR-Codex overview

This PR enhances the Curate application by adding challenge time tracking, improving UI components, updating subgraph queries, and refining data fetching functions.

Detailed summary

The following files were skipped due to too many changes: web/src/components/HistoryDisplay/Party/JustificationDetails.tsx, web/src/components/HistoryDisplay/Party/index.tsx, web/src/components/InformationCards/RegistryInformationCard/TopInfo.tsx, web/src/components/InformationCards/ItemInformationCard/index.tsx, web/src/components/HistoryDisplay/index.tsx, web/src/components/HistoryDisplay/Party/JustificationModal.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

coderabbitai[bot] commented 5 months ago

Walkthrough

This update introduces several enhancements and fixes across different parts of the project. Significant changes include adding new fields to the GraphQL schema and corresponding updates to the data handling logic in both the backend and frontend. Additionally, there are updates to the React application UI components, custom hooks for handling GraphQL data, and upgraded dependencies. The goal is to increase functionality, improve user experience, and maintainability of the codebase.

Changes

File(s) Change Summary
subgraph/schema.graphql Added externalDisputeID and challengeTime fields to the Request type.
subgraph/src/Curate.ts Updated handleRequestChallenged function to set challengeTime field.
subgraph/src/entities/Request.ts Removed Registry import, assigned externalDisputeID.
web/.env.devnet.public Updated subgraph URLs for ARBSEPOLIA and CORE services.
web/package.json Upgraded @kleros/ui-components-library dependency version.
web/src/components/HistoryDisplay/... Introduced Party, JustificationDetails, and JustificationModal components for displaying request details and handling justifications.
web/src/components/InformationCards/... Modified components to improve layout and UX, added new styled components.
web/src/components/StyledSkeleton.tsx Added new styled components for skeleton placeholders.
web/src/consts/index.ts Switched to the nullish coalescing operator for default COURT_SITE value.
web/src/context/GraphqlBatcher.tsx Modified fetcher function to accept additional isCore parameter.
web/src/hooks/queries/... Added custom hook useEvidences for fetching evidence data. Updated useRequestsQuery to include new fields.
web/src/utils/fetchJsonIpfs.ts Introduced a utility function to fetch JSON data from IPFS.

Sequence Diagram(s)

sequenceDiagram
    participant Client as Client Application
    participant API as GraphQL API
    participant IPFS as IPFS Service

    Note over Client,API: Request creation or update flow
    Client->>API: Create/Update Request (POST)
    API->>API: Save `challengeTime` & `externalDisputeID`
    API-->>Client: Confirmation response

    Note over Client,IPFS: Fetching justification details
    Client->>API: Query for evidence with Justification
    API->>IPFS: Fetch JSON from URI
    IPFS-->>API: Return JSON data
    API-->>Client: Evidence data with Justification

Poem

In the realm of code so bright,
Schema fields take flight,
With challengeTime and disputes external,
Our data flows eternal.
UI and hooks now in harmony,
A symphony of digital alchemy.
Celebrate with rabbits' cheer,
New features, oh so dear!

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
netlify[bot] commented 5 months ago

Deploy Preview for curate-v2 ready!

Name Link
Latest commit 9b026174136fdc4486ee1a7cc8c5fddef06e132b
Latest deploy log https://app.netlify.com/sites/curate-v2/deploys/6674298182acd400083911f3
Deploy Preview https://deploy-preview-42--curate-v2.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jaybuidl commented 5 months ago

image

1) Let's make sure that the copied address and the display address is the same

2) Let's make the address label a link going to the explorer + remove the explorer icon