search

kleros / gtcr

Web client for the kleros generalized token curated list
https://curate.kleros.io
MIT License
17 stars 10 forks source link

fix: address explorer link on goerli #268

Closed Params10 closed 1 year ago

Params10 commented 1 year ago

fix : address explorer link on goerli

closes #267

netlify[bot] commented 1 year ago

Deploy request for gtcr-dev pending review.

Visit the deploys page to approve it

Name Link
Latest commit dfa25aa2f6ce419efb506cf98e34195533c595fe
sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

greenlucid commented 1 year ago

hey, please put a more descriptive commit message next time like:

fix: address explorer link on goerli

closes #267
Params10 commented 1 year ago

Sorry, for the inconvenience will make sure that happens everytime .

greenlucid commented 1 year ago

Hey, I ended up fixing it differently. Instead of keeping with the redundant network data, just unified it so that the whole application consumes it from the same file https://github.com/kleros/gtcr/commit/104dea3a461b9739d45a498be2e30d0810de7203 @Params10 I suggest you take notice of the standard commit format:

1st line is a short, concise explanation of the change then, an - empty line - here there's an optional paragraph that you can use to write extra details, explanations of why you chose to make it that way, etc. (another empty line if you added the previous optional paragraph) and then, to automatically close issues, closes #a #b #c ..., although usually you will want to keep your commits small so that they're easier to review