search

kleros / gtcr

Web client for the kleros generalized token curated list
https://curate.kleros.io
MIT License
17 stars 10 forks source link

Fix/footer explorer link #270

Closed gratestas closed 1 year ago

gratestas commented 1 year ago

updated the footer and added block explorer links to light/classic TCR

fixes #166 #167

greenlucid commented 1 year ago

On #166: The footer still exists. There's an Etherscan icon but it just links to the TCR page it's being rendered on. Were you intending on removing it?

It doesn't say "Secured by Kleros" as #167 mentions. Was "Secured by Kleros" decided to be scrapped? In that case #167 should just be closed.

gratestas commented 1 year ago

@greenlucid Checked it and it seems good locally. This is how it renders

image

The intended change happens in this commit. A wrong version of the footer component is imported there. So I just changed the path

greenlucid commented 1 year ago

I'm getting this instead. Did you push your changes?

image

gratestas commented 1 year ago

@greenlucid yes, I did.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication