search

kleros / gtcr

Web client for the kleros generalized token curated list
https://curate.kleros.io
MIT License
17 stars 10 forks source link

feat: get less things from rpc #302

Closed greenlucid closed 1 year ago

greenlucid commented 1 year ago

item-details and light item details still rely on some rpc calls this is because a lot of data wrangling was required for children components and expected properties were unexpected. a lot of error handling code was removed, some errors are still possible.

sonarcloud[bot] commented 1 year ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 18 Code Smells

No Coverage information No Coverage information
19.0% 19.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

jaybuidl commented 1 year ago

I have just rebased this on top of the latest version of dev which includes the fix for Goerli from #303

Looking at the deployment preview, it works well for Mainnet and Gnosis but not for Goerli, can you take a look @greenlucid pls? image

greenlucid commented 1 year ago

it doesn't work in goerli because the initial metaevidence wasn't set properly due to a bug. when this: https://github.com/kleros/gtcr-subgraph/pull/19 is merged and deployed, it'll work again