kleros / gtcr

Web client for the kleros generalized token curated list
https://curate.kleros.io
MIT License
17 stars 10 forks source link

fix(web): submit-booleans-and-default-types-as-strings #329

Closed kemuru closed 5 months ago

kemuru commented 5 months ago

examples:

before this change, the default value of number was number, but once you modified it, it became a string. and the default value of boolean was boolean, and once you modified it, it stayed boolean too, when it shouldve been a string for being uploaded into the IPFS json string object

ATQ Registry, before (without inputting anything in the number value):

image

after (without inputting anything in the number value):

image

ATQ Registry, before (inputting something in the number value):

image

after (inputting something in the number value):

image

AT Registry, before and after are the same:

image

Token Registry, before and after are the same:

image
sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud