search

kleros / kleros-juror-front

The front end for Kleros jurors.
MIT License
8 stars 5 forks source link

Show all periods #113

Open clesaege opened 6 years ago

clesaege commented 6 years ago

Currently the bar just show how we are in the current period

session

It would be way better to show all periods like what we did for the IICO.

epiqueras commented 6 years ago

@satello Will you store the time at which pass period was called?

satello commented 6 years ago

We don't know exact times because it takes a variable amount of time for the pass period tx to get mined. What do you need them stored for?

satello commented 6 years ago

@epiqueras we can just look up the NewPeriod event for a timestamp

epiqueras commented 6 years ago

@satello To show the timeline. Yeah, that works.

satello commented 6 years ago

@epiqueras how accurate does it have to be? We could also just estimate backwards and forwards based on timePerPeriod which is much simpler

epiqueras commented 6 years ago

@satello That could be way off, but I guess the bot is always passing the period so it's fine.

satello commented 6 years ago

@epiqueras It could be way off on estimating the future period times as well. I think it is safe for now to assume the bot will be passing the periods within a reasonable margin of error of when its supposed to end. Probably long term it is best to get all timestamps so we can be exact but for the pilot estimating seems fine. It would also be more calls to the blockchain to slow down the page render

epiqueras commented 6 years ago

@satello Yeah, I am fine with estimating.