search

kleros / kleros-juror-front

The front end for Kleros jurors.
MIT License
8 stars 5 forks source link

fix: add message when there is no web3 - issue #129 #131

Closed eburgos closed 6 years ago

eburgos commented 6 years ago

Added a message when there is no Metamask installed in your browser. Requested by issue #129

epiqueras commented 6 years ago

What happens if accounts are still loading?

eburgos commented 6 years ago

@epiqueras I tested with a browser with metamask unlocked, locked and no metamask. How does my metamask need to be configured to get the "Loading" state? Do I need to have multiple accounts?

epiqueras commented 6 years ago

Loading happens because the accounts are fetched asynchronously. See accounts.loading, in that case you are also showing the RequiresMetaMask component, even though they might have MetaMask, but the request is still loading.

eburgos commented 6 years ago

Yes, I now see what you mean.

eburgos commented 6 years ago

Could that work @epiqueras ? Tested with metamask and shows Loading... then with no metamask and shows the download one.

epiqueras commented 6 years ago

That works. Please fix linting errors and submit the PR against the develop branch.