kleros / kleros-juror-front

The front end for Kleros jurors.
MIT License
8 stars 5 forks source link

fix: add message when there is no web3 #133

Closed eburgos closed 6 years ago

eburgos commented 6 years ago

Added a message when there is no Metamask installed in your browser. Requested by issue #129

eburgos commented 6 years ago

Lint passes well @epiqueras

epiqueras commented 6 years ago

I tested on incognito mode (no web3), and it still passes the first if statement after it fails to fetch:

https://github.com/kleros/kleros-juror-front/blob/0e21058800019280a46ef5bb27937a0cd1b948c3/src/bootstrap/initializer.js#L42

So I added the if guard here:

https://github.com/kleros/kleros-juror-front/blob/0e21058800019280a46ef5bb27937a0cd1b948c3/src/bootstrap/initializer.js#L43

eburgos commented 6 years ago

do I need to do something?

epiqueras commented 6 years ago

No, all good.