search

kleros / kleros-v2

Kleros version 2
https://v2.kleros.builders
MIT License
61 stars 43 forks source link

Update Solc version from 0.8.18 to 0.8.24 #1567

Closed Anmol-Dhiman closed 5 months ago

Anmol-Dhiman commented 6 months ago

Need to change the sol version in node_modules -

Test Result -

Screenshot 2024-04-22 at 5 05 59 PM

Issue #1510

PR-Codex overview

This PR updates the Solidity version to 0.8.24 and adjusts import paths for OpenZeppelin contracts and Kleros VeA contracts.

Detailed summary

The following files were skipped due to too many changes: contracts/src/libraries/SortitionSumTreeFactory.sol, contracts/src/rng/BlockhashRNG.sol, contracts/src/arbitration/university/SortitionModuleUniversity.sol, contracts/src/rng/RandomizerRNG.sol, contracts/src/arbitration/KlerosCoreBase.sol, contracts/src/arbitration/university/KlerosCoreUniversity.sol, contracts/src/token/TestERC721.sol, contracts/src/kleros-v1/kleros-liquid-xdai/xKlerosLiquidV2.sol, contracts/src/arbitration/KlerosGovernor.sol, contracts/src/arbitration/CentralizedArbitrator.sol, contracts/src/gateway/ForeignGateway.sol, contracts/src/arbitration/dispute-kits/DisputeKitClassic.sol, contracts/src/kleros-v1/kleros-liquid/KlerosLiquidToV2Governor.sol, contracts/src/arbitration/SortitionModuleBase.sol, contracts/src/arbitration/dispute-kits/DisputeKitSybilResistant.sol, contracts/src/arbitration/evidence/ModeratedEvidenceModule.sol, yarn.lock

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

These changes enhance the overall security, readability, and maintainability of the codebase, ensuring compatibility with the latest Solidity features and improvements.

netlify[bot] commented 6 months ago

Deploy Preview for kleros-v2 ready!

Name Link
Latest commit 07a593b4cfcf889c6babd1bc8eacdec33cd148c6
Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/6660cb9dc8557600082b1d9a
Deploy Preview https://deploy-preview-1567--kleros-v2.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 6 months ago

Deploy Preview for kleros-v2-neo ready!

Name Link
Latest commit 07a593b4cfcf889c6babd1bc8eacdec33cd148c6
Latest deploy log https://app.netlify.com/sites/kleros-v2-neo/deploys/6660cb9d6db04d00083ad990
Deploy Preview https://deploy-preview-1567--kleros-v2-neo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 6 months ago

Deploy Preview for kleros-v2-university ready!

Name Link
Latest commit 07a593b4cfcf889c6babd1bc8eacdec33cd148c6
Latest deploy log https://app.netlify.com/sites/kleros-v2-university/deploys/6660cb9d6ab6c20008d4e2e4
Deploy Preview https://deploy-preview-1567--kleros-v2-university.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

coderabbitai[bot] commented 5 months ago

[!IMPORTANT]

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1) * dependencies

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The updates primarily involve upgrading the Solidity version from 0.8.18 to 0.8.24 across various contracts, interfaces, and configuration files, ensuring compatibility with the latest Solidity features and improvements. Additionally, several mappings within structs and contracts have been updated for better readability and clarity by using more descriptive key names.

Changes

Files/Paths Change Summary
contracts/hardhat.config.ts Updated Solidity version from 0.8.18 to 0.8.24.
contracts/package.json Upgraded @openzeppelin/contracts from ^4.9.5 to ^5.0.2.
contracts/src/arbitration/... Updated Solidity version from 0.8.18 to 0.8.24 across multiple arbitration-related contracts.
contracts/src/arbitration/... Modified mappings within structs for better clarity and readability.
contracts/src/arbitration/interfaces/... Updated Solidity version from 0.8.18 to 0.8.24 across multiple interface files.
contracts/src/gateway/... Updated Solidity version from 0.8.18 to 0.8.24 in gateway-related contracts and interfaces.

"In the realm of code so bright, Solidity marched to a higher height. From 0.8.18 to .24, Mappings clearer than before. Contracts and interfaces, all aligned, CodeRabbit's joy, truly defined!"

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codeclimate[bot] commented 5 months ago

Code Climate has analyzed commit 07a593b4 and detected 0 issues on this pull request.

View more on Code Climate.