Closed ShubhamParkhi closed 3 months ago
Name | Link |
---|---|
Latest commit | 955a35dce79dd23945a9dcab68427fad511f6841 |
Latest deploy log | https://app.netlify.com/sites/kleros-v2/deploys/664fbfedc520bf00083471b3 |
Deploy Preview | https://deploy-preview-1583--kleros-v2.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Visit the deploys page to approve it
Name | Link |
---|---|
Latest commit | 955a35dce79dd23945a9dcab68427fad511f6841 |
Visit the deploys page to approve it
Name | Link |
---|---|
Latest commit | 955a35dce79dd23945a9dcab68427fad511f6841 |
[!IMPORTANT]
Review Skipped
Auto reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Negative numbers not handled in withdraw. Fine for staking.
Errors do not go away when you interact with the InputDisplay Field, I think we should rethink this in another way. I think contract errors should not be displayed for users, as they are too strange and technical. I've tried modifying this a bit, maybe something like this? probably without the "hasInteracted" variable since we are already not showing errors if the parsedAmount === 0n
Agreed , technical errors should not be displayed, logging them to console should be fine.
insufficient balance
warning (not error), while staking. Otherwise, it's not necessary as the balance displayed above should be enoughCode Climate has analyzed commit 955a35dc and detected 1 issue on this pull request.
Here's the issue category breakdown:
Category | Count |
---|---|
Style | 1 |
View more on Code Climate.
continued on #1585
The changes in hook checks if the isAllowance flag is true. If it is, it sets an error message based on whether parsedAmount is zero or if there’s an allowanceError. If isAllowance is false, it does a similar check but for setStakeError instead.
Breakdown of the conditions:
PR-Codex overview
The focus of this PR is to add a
min
prop to theNumberInputField
component and handle error messages in stake operations.Detailed summary
min
prop toNumberInputField
setErrorMsg
prop