search

kleros / kleros-v2

Kleros version 2
https://v2.kleros.builders
MIT License
58 stars 41 forks source link

Upgrade hardhat, hardhat-deploy, ethers #1606

Open jaybuidl opened 2 months ago

jaybuidl commented 2 months ago

Our current Hardhat-related package versions have been held back significantly after Hardhat has moved to Ethers v6. We using the last versions which are still compatible with Ethers v5.

Ethers v6 introduces many small API breaks, which will likely break many scripts inside ./contracts/deploy and ./contract/scripts.

Packages and versions

We need to migrate to versions which are aligned with Curate-v2 and Escrow-v2.

    "@nomicfoundation/hardhat-chai-matchers": "^2.0.0",
    "@nomicfoundation/hardhat-ethers": "^3.0.0",
    "@nomicfoundation/hardhat-network-helpers": "^1.0.0",
    "@nomicfoundation/hardhat-verify": "^2.0.0",
    "@nomiclabs/hardhat-solhint": "^3.0.1",
    "@typechain/ethers-v6": "^0.5.0",
    "@typechain/hardhat": "^9.1.0",
    "ethers": "^6.10.0",
    "hardhat": "^2.19.0",
    "hardhat-deploy": "^0.11.45",
    "hardhat-deploy-ethers": "^0.4.1",
    "hardhat-docgen": "^1.3.0",
    "hardhat-gas-reporter": "^1.0.8",
    "hardhat-watcher": "^2.5.0",

Extra requirement

The solidity-coverage workflow should pass. It has been failing presumably because of this issue.

To replicate it: yarn hardhat coverage --solcoverjs ./.solcover.js --temp artifacts --testfiles \"./test/**/*.ts\" --show-stack-traces