Open Anmol-Dhiman opened 2 months ago
The changes involve updating multiple deployment and utility scripts to align with the newer versions of Hardhat and Ethers.js libraries. This includes adjustments to import statements, function calls, and variable assignments to be compatible with the breaking changes introduced in Ethers v6. Various parts of the deployment workflow have been modified to address these updates while ensuring the functionality and integration tests, especially related to Solidity coverage, continue to work correctly.
Files/Directories | Change Summaries |
---|---|
All Deploy Scripts | Replaced AddressZero with ZeroAddress , updated function call arguments, and modified import statements for updated ethers functions. |
.../00-home-chain-arbitration-neo.ts |
Updated variable assignments, function arguments, and imports to use new Ethers methodology. |
.../00-home-chain-arbitration-university.ts |
Similar updates as above for specific use cases and arguments. |
.../00-home-chain-arbitration.ts |
Applied relevant updates to argument handling and function calls. |
.../00-home-chain-pnk-faucet.ts |
Modified usage of parseUnits function to align with new ethers structure. |
.../01-foreign-gateway-on-ethereum.ts |
Updated import and function call patterns, renamed certain imports. |
.../01-foreign-gateway-on-gnosis.ts |
Changed import statements, adjusted usage of BigNumber and function calls. |
.../02-home-gateway-to-ethereum.ts |
Replaced AddressZero with ZeroAddress in specific deployment steps. |
.../03-vea-mock.ts |
Updated import and variable usage to match the new ethers utilities. |
.../04-foreign-arbitrable.ts |
Adjusted imports for parseUnits and BigNumber ; updated function usages accordingly. |
.../04-klerosliquid-to-v2-gnosis.ts |
Modified import patterns; updated constant definitions involving BigNumber . |
.../05-arbitrable-dispute-template.ts |
Added EventLog import and modified event handling logic in deployment process. |
.../fix1148.ts |
Updated function arguments and variable initializations to use ZeroAddress and new ethers methods. |
.../upgrade-kleros-core.ts |
Replaced BigNumber with toBigInt in certain calculations; updated variable usage. |
.../utils/deployTokens.ts |
Modified imports, parameter types, and variable usage to new ethers methods. |
.../utils/getContractOrDeploy.ts |
Refined contract retrieval and deployment logic; updated to new ethers import. |
.../utils/index.ts |
Replaced parseUnits function usage to align with new ether structure. |
.../utils/klerosCoreHelper.ts |
Included toBigInt import and altered some conditional statements. |
.../package.json |
Updated various package versions to latest releases compatible with Ethers v6. |
.../scripts/deploy.ts |
Changed deployment transaction handling and logging statement adjustments. |
.../scripts/disputeCreatorBot.ts |
Updated function calls and event handling logic. |
.../scripts/getCourtsV1.ts |
Replaced AddressZero with ZeroAddress and updated number extraction methods. |
.../scripts/getPoliciesV1.ts |
Updated constant declaration to use ZeroAddress from ethers. |
.../scripts/keeperBot.ts |
Modified imports and function call methodologies to adapt new ethers standards. |
.github/.../contracts-testing.yml |
Adjusted test command syntax within contracts testing workflow script. |
./contracts/deploy
and ./contracts/scripts
.In the land of code so bright,
Packages evolved to newer might,
Ethers v6 brings subtle cheer,
Hardhat's updates make it clear,
Scripts now dance to a brand new tune,
Keeping bugs far at bay, like the moon,
CodeRabbit cheers, "Deploy and test away!" ππ
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Name | Link |
---|---|
Latest commit | b1e463208af4525ec24f9e5fb7104ef118cafd59 |
Latest deploy log | https://app.netlify.com/sites/kleros-v2-neo/deploys/667bbf0aa886b1000804f661 |
Name | Link |
---|---|
Latest commit | b1e463208af4525ec24f9e5fb7104ef118cafd59 |
Latest deploy log | https://app.netlify.com/sites/kleros-v2/deploys/667bbf0a0637900008fc1571 |
Name | Link |
---|---|
Latest commit | b1e463208af4525ec24f9e5fb7104ef118cafd59 |
Latest deploy log | https://app.netlify.com/sites/kleros-v2-university/deploys/667bbf0a5527b90008cf19e0 |
Code Climate has analyzed commit b1e46320 and detected 40 issues on this pull request.
Here's the issue category breakdown:
Category | Count |
---|---|
Complexity | 3 |
Duplication | 28 |
Style | 9 |
View more on Code Climate.
Issues
10 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
2.0% Duplication on New Code
PR-Codex overview
This PR updates various parts of the codebase to use
ethers
v6, fix styling in components, and improve contract deployment scripts.Detailed summary
ethers
imports and usage to version 6.Timestamp
component.Summary by CodeRabbit
Refactor
AddressZero
withZeroAddress
for consistency.ethers
library version.Chores
package.json
to their latest versions for better performance and security.