kleros / kleros-v2

Kleros version 2
https://v2.kleros.builders
MIT License
58 stars 41 forks source link

Chore(hardhat)/hardhat ether version update #1620

Open Anmol-Dhiman opened 2 months ago

Anmol-Dhiman commented 2 months ago

PR-Codex overview

This PR updates various parts of the codebase to use ethers v6, fix styling in components, and improve contract deployment scripts.

Detailed summary

The following files were skipped due to too many changes: contracts/deploy/utils/getContractOrDeploy.ts, contracts/deploy/utils/deployTokens.ts, contracts/deploy/01-foreign-gateway-on-ethereum.ts, contracts/deploy/upgrade-kleros-core.ts, contracts/deploy/fix1148.ts, contracts/deploy/03-vea-mock.ts, contracts/deploy/01-foreign-gateway-on-gnosis.ts, contracts/test/proxy/index.ts, contracts/deploy/00-home-chain-arbitration.ts, contracts/test/rng/index.ts, contracts/scripts/simulations/utils.ts, contracts/deploy/00-home-chain-arbitration-neo.ts, contracts/deploy/00-home-chain-arbitration-university.ts, contracts/scripts/populateCourts.ts, contracts/test/arbitration/index.ts, contracts/test/integration/index.ts, contracts/test/evidence/index.ts, contracts/test/arbitration/staking.ts, contracts/scripts/simulations/tasks.ts, contracts/test/arbitration/draw.ts, contracts/scripts/keeperBot.ts, contracts/test/arbitration/staking-neo.ts, yarn.lock

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

coderabbitai[bot] commented 2 months ago

Walkthrough

The changes involve updating multiple deployment and utility scripts to align with the newer versions of Hardhat and Ethers.js libraries. This includes adjustments to import statements, function calls, and variable assignments to be compatible with the breaking changes introduced in Ethers v6. Various parts of the deployment workflow have been modified to address these updates while ensuring the functionality and integration tests, especially related to Solidity coverage, continue to work correctly.

Changes

Files/Directories Change Summaries
All Deploy Scripts Replaced AddressZero with ZeroAddress, updated function call arguments, and modified import statements for updated ethers functions.
.../00-home-chain-arbitration-neo.ts Updated variable assignments, function arguments, and imports to use new Ethers methodology.
.../00-home-chain-arbitration-university.ts Similar updates as above for specific use cases and arguments.
.../00-home-chain-arbitration.ts Applied relevant updates to argument handling and function calls.
.../00-home-chain-pnk-faucet.ts Modified usage of parseUnits function to align with new ethers structure.
.../01-foreign-gateway-on-ethereum.ts Updated import and function call patterns, renamed certain imports.
.../01-foreign-gateway-on-gnosis.ts Changed import statements, adjusted usage of BigNumber and function calls.
.../02-home-gateway-to-ethereum.ts Replaced AddressZero with ZeroAddress in specific deployment steps.
.../03-vea-mock.ts Updated import and variable usage to match the new ethers utilities.
.../04-foreign-arbitrable.ts Adjusted imports for parseUnits and BigNumber; updated function usages accordingly.
.../04-klerosliquid-to-v2-gnosis.ts Modified import patterns; updated constant definitions involving BigNumber.
.../05-arbitrable-dispute-template.ts Added EventLog import and modified event handling logic in deployment process.
.../fix1148.ts Updated function arguments and variable initializations to use ZeroAddress and new ethers methods.
.../upgrade-kleros-core.ts Replaced BigNumber with toBigInt in certain calculations; updated variable usage.
.../utils/deployTokens.ts Modified imports, parameter types, and variable usage to new ethers methods.
.../utils/getContractOrDeploy.ts Refined contract retrieval and deployment logic; updated to new ethers import.
.../utils/index.ts Replaced parseUnits function usage to align with new ether structure.
.../utils/klerosCoreHelper.ts Included toBigInt import and altered some conditional statements.
.../package.json Updated various package versions to latest releases compatible with Ethers v6.
.../scripts/deploy.ts Changed deployment transaction handling and logging statement adjustments.
.../scripts/disputeCreatorBot.ts Updated function calls and event handling logic.
.../scripts/getCourtsV1.ts Replaced AddressZero with ZeroAddress and updated number extraction methods.
.../scripts/getPoliciesV1.ts Updated constant declaration to use ZeroAddress from ethers.
.../scripts/keeperBot.ts Modified imports and function call methodologies to adapt new ethers standards.
.github/.../contracts-testing.yml Adjusted test command syntax within contracts testing workflow script.

Possibly related issues

Poem

In the land of code so bright,
Packages evolved to newer might,
Ethers v6 brings subtle cheer,
Hardhat's updates make it clear,
Scripts now dance to a brand new tune,
Keeping bugs far at bay, like the moon,
CodeRabbit cheers, "Deploy and test away!" πŸŒ•πŸŒŸ


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
netlify[bot] commented 2 months ago

Deploy Preview for kleros-v2-neo failed. Why did it fail? β†’

Name Link
Latest commit b1e463208af4525ec24f9e5fb7104ef118cafd59
Latest deploy log https://app.netlify.com/sites/kleros-v2-neo/deploys/667bbf0aa886b1000804f661
netlify[bot] commented 2 months ago

Deploy Preview for kleros-v2 failed. Why did it fail? β†’

Name Link
Latest commit b1e463208af4525ec24f9e5fb7104ef118cafd59
Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/667bbf0a0637900008fc1571
netlify[bot] commented 2 months ago

Deploy Preview for kleros-v2-university failed. Why did it fail? β†’

Name Link
Latest commit b1e463208af4525ec24f9e5fb7104ef118cafd59
Latest deploy log https://app.netlify.com/sites/kleros-v2-university/deploys/667bbf0a5527b90008cf19e0
codeclimate[bot] commented 1 month ago

Code Climate has analyzed commit b1e46320 and detected 40 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 3
Duplication 28
Style 9

View more on Code Climate.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.0% Duplication on New Code

See analysis details on SonarCloud