fix: add externaldisputeid to query key in populate hook, remove must…

kemuru commented 1 month ago

…ache log

PR-Codex overview

This PR updates the usePopulatedDisputeData hook to include a new condition externalDisputeID for enabling query execution.

Detailed summary

Updated isEnabled condition to include externalDisputeID
Updated queryKey in useQuery to include externalDisputeID

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

Improvements
- Enhanced dispute data querying logic to include checks for externalDisputeID, improving accuracy and robustness.
Optimization
- Removed unnecessary console logging when rendering templates, resulting in cleaner console output.

coderabbitai[bot] commented 1 month ago

Walkthrough

These changes enhance the functionality of the populateTemplate and usePopulatedDisputeData functions within the Kleros SDK and web application. The removal of console logging in populateTemplate helps streamline the code, while the updates in usePopulatedDisputeData improve query enabling logic by considering externalDisputeID. This strengthens data handling for disputes, ensuring better integration and fewer errors.

Changes

File Path	Change Summary
kleros-sdk/src/.../populateTemplate.ts	Removed "MUSTACHE RENDER" console log before parsing the render result.
web/src/hooks/queries/usePopulatedDisputeData.ts	Updated `isEnabled` logic to include `!isUndefined(externalDisputeID)`. Altered `queryKey` to include `externalDisputeID`.

Poem

🐇✨ In code we weave, the changes slight, 🛠️ No more logs in template's light. Queries now more finely tuned, Disputes resolved and data pruned. 🕸️ Across the chains we boldly stride, With logic sharp, we code with pride.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

codeclimate[bot] commented 1 month ago

Code Climate has analyzed commit fb01ed8c and detected 0 issues on this pull request.

View more on Code Climate.

sonarcloud[bot] commented 1 month ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

netlify[bot] commented 1 month ago

Deploy Preview for kleros-v2 canceled.

Name	Link
Latest commit	82b73f67eb7eabca349667cae6240a8f2b18c62e
Latest deploy log	https://app.netlify.com/sites/kleros-v2/deploys/667ea774be836c00083c5f87

netlify[bot] commented 1 month ago

Deploy Preview for kleros-v2-neo ready!

Name	Link
Latest commit	fb01ed8c8067562d37fa530e2691e11408d80957
Latest deploy log	https://app.netlify.com/sites/kleros-v2-neo/deploys/667ea7849bd7f00008c6fafc
Deploy Preview	https://deploy-preview-1633--kleros-v2-neo.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 month ago

Deploy Preview for kleros-v2-university ready!

Name	Link
Latest commit	fb01ed8c8067562d37fa530e2691e11408d80957
Latest deploy log	https://app.netlify.com/sites/kleros-v2-university/deploys/667ea78547aac30008aa5883
Deploy Preview	https://deploy-preview-1633--kleros-v2-university.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 month ago

Deploy Preview for kleros-v2 ready!

Name	Link
Latest commit
Latest deploy log	https://app.netlify.com/sites/kleros-v2/deploys/667eaa820c97fb2b566ea86a
Deploy Preview	https://deploy-preview-1633--kleros-v2.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

kleros / kleros-v2