Closed Harman-singh-waraich closed 1 month ago
The changes across various modules and files center around updating the way evidence is handled in the arbitration system. Instead of using IPFS paths, the system now expects a stringified JSON object containing fields like "name", "description", and "fileURI". Additionally, full-text search capabilities have been introduced, and several components were refactored to support these updates.
File Path | Summary of Changes |
---|---|
contracts/src/arbitration/.../EvidenceModule.sol |
Changed submitEvidence to accept a stringified evidence object instead of an IPFS path. |
contracts/src/arbitration/.../ModeratedEvidenceModule.sol |
Updated event and function parameter descriptions to use a stringified evidence object format. |
contracts/src/arbitration/.../IEvidence.sol |
Modified Evidence event parameter to accept a stringified evidence object. |
subgraph/core/schema.graphql |
Added fields like name , description , fileURI , fileTypeExtension to Evidence and ClassicEvidence types. |
subgraph/core-neo/subgraph.yaml , subgraph/core-university/subgraph.yaml , subgraph/core/subgraph.yaml |
Introduced fullTextSearch feature and added KlerosCore data source for Ethereum. |
subgraph/core/src/EvidenceModule.ts |
Enhanced handleEvidenceEvent to parse and extract fields from stringified evidence objects, with added error handling. |
subgraph/package.json |
Updated project version from 0.5.1 to 0.7.0 . |
web/src/components/EvidenceCard.tsx |
Refactored EvidenceCard component to use new props for rendering evidence, removing reliance on useIPFSQuery . |
web/src/hooks/queries/useEvidences.ts |
Updated evidencesQuery to include new evidence fields and specified type parameter for useQuery . |
web/src/pages/Cases/CaseDetails/.../SubmitEvidenceModal.tsx |
Refactored submitEvidence function to handle evidence submission more efficiently and improved error handling. |
web/src/pages/Cases/CaseDetails/.../index.tsx |
Refactored evidence display logic, added scroll-to-latest feature, and replaced several hooks and components. |
web/src/pages/Cases/CaseDetails/.../EvidenceSearch.tsx |
Introduced EvidenceSearch component for searching evidence with dynamic filtering and blockchain connectivity checks. |
sequenceDiagram
participant User
participant Frontend
participant SmartContract
participant IPFS
User->>Frontend: SubmitEvidence (name, description, fileURI)
Frontend->>IPFS: Upload file
IPFS-->>Frontend: fileURI
Frontend->>SmartContract: submitEvidence(externalDisputeID, evidenceJSON)
SmartContract->>Frontend: Emit Evidence Event
Frontend->>Frontend: handleEvidenceEvent
Frontend->>Database: Save Evidence (parsed JSON)
A change in code, so swift and bright,
Evidence now in JSON light.
Fields of name, and description too,
Full-text search to find what's true.
A bunny hops with joy, delight,
For updates come and bugs take flight.
🌟🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Name | Link |
---|---|
Latest commit | d1b6fe2b9b456562c5b034748509e06579c95dd8 |
Latest deploy log | https://app.netlify.com/sites/kleros-v2/deploys/66992be2b15ba90008e05caa |
Deploy Preview | https://deploy-preview-1634--kleros-v2.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Name | Link |
---|---|
Latest commit | d1b6fe2b9b456562c5b034748509e06579c95dd8 |
Latest deploy log | https://app.netlify.com/sites/kleros-v2-neo/deploys/66992be2bd7df80008b18163 |
Deploy Preview | https://deploy-preview-1634--kleros-v2-neo.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Name | Link |
---|---|
Latest commit | d1b6fe2b9b456562c5b034748509e06579c95dd8 |
Latest deploy log | https://app.netlify.com/sites/kleros-v2-university/deploys/66992be2e03865000889387a |
Deploy Preview | https://deploy-preview-1634--kleros-v2-university.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Code Climate has analyzed commit d1b6fe2b and detected 15 issues on this pull request.
Here's the issue category breakdown:
Category | Count |
---|---|
Complexity | 2 |
Duplication | 2 |
Style | 11 |
View more on Code Climate.
Issues
1 New issue
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
⚠️ Will need contract redeploys, natspec has been updated for EvidenceModule.
more info and context : https://hackmd.io/@-cmxt73kRVi2uFMhhabm4A/BkGylT58R
To be done :-
PR-Codex overview
This PR updates the Kleros v2 subgraph, adds full-text search feature, improves evidence submission handling, and enhances UI components.
Detailed summary
Summary by CodeRabbit
New Features
name
,description
,fileURI
,fileTypeExtension
) to evidence handling.EvidenceSearch
component for enhanced evidence search and submission.Refactor
EvidenceCard
and related components to utilize new evidence fields.Chores
@kleros/kleros-v2-subgraph
from0.5.1
to0.7.0
.