kleros / kleros-v2

Kleros version 2
https://v2.kleros.builders
MIT License
62 stars 44 forks source link

Maintenance buttons at arbitrator-level #1668

Closed Harman-singh-waraich closed 3 months ago

Harman-singh-waraich commented 3 months ago

builds upon #1645 , please merge the previous one first

Adds arbitrator level maintenance buttons as Courts page


PR-Codex overview

This PR updates subgraph version, refactors maintenance buttons, and adds stake maintenance features to the Courts page.

Detailed summary

The following files were skipped due to too many changes: web/src/pages/Courts/StakeMaintenanceButton/PassPhaseButton.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

netlify[bot] commented 3 months ago

Deploy Preview for kleros-v2-university canceled.

Name Link
Latest commit ec0e43f7b0236d3ccc4d3aab06b2010c71a2bdca
Latest deploy log https://app.netlify.com/sites/kleros-v2-university/deploys/66b35c2d7c6b3d0008b9592d
netlify[bot] commented 3 months ago

Deploy Preview for kleros-v2-testnet ready!

Name Link
Latest commit 5d9bf8e3a5560c06b3b6df09ca59a3550f8b0d63
Latest deploy log https://app.netlify.com/sites/kleros-v2-testnet/deploys/66b35d0f35b5610007ef9afa
Deploy Preview https://deploy-preview-1668--kleros-v2-testnet.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 3 months ago

Deploy Preview for kleros-v2-neo failed. Why did it fail? β†’

Name Link
Latest commit 5d9bf8e3a5560c06b3b6df09ca59a3550f8b0d63
Latest deploy log https://app.netlify.com/sites/kleros-v2-neo/deploys/66b35d0fe8a7230008d624ad
coderabbitai[bot] commented 3 months ago

Walkthrough

The recent updates introduce significant enhancements across various system components. Key additions include the TransactionBatcher smart contract for streamlined transaction management, enriched GraphQL queries for improved data retrieval, and new React components that enhance user interaction in dispute management. Collectively, these changes optimize operations, elevate user experience, and clarify interactions with the blockchain.

Changes

File(s) Change Summary
contracts/README.md Added entries for the TransactionBatcher contract with proxy links for mainnet and testnet.
contracts/deploy/00-transaction-batcher.ts Introduced deployment script for TransactionBatcher, managing network conditions and deployment utilities.
contracts/deployments/arbitrum/TransactionBatcher.json
contracts/deployments/arbitrumSepoliaDevnet/TransactionBatcher.json
Added deployment details and ABI for TransactionBatcher, including functions for batch sending Ether.
subgraph/core/schema.graphql Updated GraphQL schema for Round and ClassicRound to include new fields for juror management and fee distribution.
subgraph/core/src/DisputeKitClassic.ts Modified logic for handling appeal costs and fee management in disputes.
subgraph/core/src/KlerosCore.ts Enhanced handling of dispute rounds, including state tracking for jurors and reward distribution.
web/src/components/DottedMenuButton.tsx Introduced a new button component featuring a ripple effect for enhanced UI interaction.
web/src/hooks/queries/useClassicAppealQuery.ts
web/src/hooks/queries/useDisputeDetailsQuery.ts
web/src/hooks/queries/useDisputeMaintenanceQuery.ts
Extended GraphQL queries to include new fields for better data management related to disputes and appeals.
web/src/pages/Cases/CaseDetails/MaintenanceButtons/* Implemented multiple new components for managing dispute actions, including distributing rewards and managing periods.
web/src/utils/getLocalRounds.ts Refactored getLocalRounds function for enhanced type safety and flexibility using generics.
web/src/pages/Cases/CaseDetails/MaintenanceButtons/PassPeriodButton.tsx Updated PassPeriodButton to improve state management with a fallback value for isDrawn.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UI
    participant TransactionBatcher
    participant Blockchain

    User->>UI: Clicks to send batch transaction
    UI->>TransactionBatcher: Prepare transaction data
    TransactionBatcher->>Blockchain: Execute batch transaction
    Blockchain-->>TransactionBatcher: Transaction result
    TransactionBatcher-->>UI: Update UI based on result
    UI-->>User: Show success/failure message

πŸ‡ In the land of code where the rabbits play,
New features hop in, brightening the day.
Batching transactions, oh what a delight,
User interfaces spark joy, shining bright!
With every click, a dance of success,
Hooray for the changes, we’re truly blessed! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codeclimate[bot] commented 3 months ago

Code Climate has analyzed commit 5d9bf8e3 and detected 11 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2
Duplication 7
Style 2

View more on Code Climate.

sonarcloud[bot] commented 3 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
17.7% Duplication on New Code (required ≀ 10%)

See analysis details on SonarCloud