kleros / kleros-v2

Kleros version 2
https://v2.kleros.builders
MIT License
61 stars 43 forks source link

feat(web): ruling-and-rewards-indicators #1676

Closed Harman-singh-waraich closed 3 weeks ago

Harman-singh-waraich commented 4 weeks ago

PR-Codex overview

The focus of this PR is to add new indicators in the voting history UI and improve vote details visibility.

Detailed summary

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

coderabbitai[bot] commented 4 weeks ago

Walkthrough

The recent changes enhance the voting history functionality by adding new GraphQL fields to retrieve more detailed information about disputes. A new React component, RulingAndRewardsIndicators, has been introduced to display status indicators for rulings and juror rewards. Furthermore, enhancements in the VotingHistory component now utilize these new indicators, improving the user interface and providing clearer insights into the voting process.

Changes

Files Change Summary
web/src/hooks/queries/useVotingHistory.ts Added ruled and jurorRewardsDispersed fields to the GraphQL query for enhanced dispute information.
web/src/pages/Cases/CaseDetails/Voting/RulingAndRewardsIndicators.tsx Introduced a new React component that displays conditional indicators for rulings and juror rewards using props.
web/src/pages/Cases/CaseDetails/Voting/VotingHistory.tsx Integrated RulingAndRewardsIndicators, enhanced layout spacing, and optimized performance with new logic for rewards distribution.
web/src/pages/Cases/CaseDetails/Voting/VotesDetails/AccordionTitle.tsx Updated VoteStatus and AccordionTitle components to accept new props for vote commitment and visibility.
web/src/pages/Cases/CaseDetails/Voting/VotesDetails/index.tsx Added hiddenVotes property to IVotesAccordion interface, enhancing the votes visibility functionality.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant VotingHistory
    participant RulingAndRewardsIndicators
    participant GraphQL

    User->>VotingHistory: Request voting details
    VotingHistory->>GraphQL: Fetch dispute data
    GraphQL-->>VotingHistory: Return dispute data with new fields
    VotingHistory->>RulingAndRewardsIndicators: Provide ruling and rewards data
    RulingAndRewardsIndicators-->>VotingHistory: Render indicators
    VotingHistory-->>User: Display voting history with indicators

Poem

πŸ‡ In the meadow where votes take flight,
New fields shimmer, oh what a sight!
Rulings and rewards, we cheer and dance,
With indicators bright, we take a chance.
Hopping along, let’s celebrate today,
For knowledge and fun in every way! πŸŽ‰


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
netlify[bot] commented 4 weeks ago

Deploy Preview for kleros-v2-testnet ready!

Name Link
Latest commit 40297711bed1970d4ab355780e474d65755a691c
Latest deploy log https://app.netlify.com/sites/kleros-v2-testnet/deploys/66c5a04728689c000839e329
Deploy Preview https://deploy-preview-1676--kleros-v2-testnet.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 4 weeks ago

Deploy Preview for kleros-v2-neo ready!

Name Link
Latest commit 40297711bed1970d4ab355780e474d65755a691c
Latest deploy log https://app.netlify.com/sites/kleros-v2-neo/deploys/66c5a0479d87160008b867c0
Deploy Preview https://deploy-preview-1676--kleros-v2-neo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 4 weeks ago

Deploy Preview for kleros-v2-university failed. Why did it fail? β†’

Name Link
Latest commit 40297711bed1970d4ab355780e474d65755a691c
Latest deploy log https://app.netlify.com/sites/kleros-v2-university/deploys/66c5a047f637e400083e09d9
codeclimate[bot] commented 3 weeks ago

Code Climate has analyzed commit 40297711 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2
Style 1

View more on Code Climate.

sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud