kleros / kleros-v2

Kleros version 2
https://v2.kleros.builders
MIT License
62 stars 44 forks source link

Kleros SDK publication config #1704

Closed jaybuidl closed 1 month ago

jaybuidl commented 1 month ago

PR-Codex overview

This PR primarily focuses on restructuring and enhancing the kleros-sdk project by updating type definitions, improving type safety, and modifying the GraphQL integration. It also updates configuration files and modifies various action imports for better clarity and organization.

Detailed summary

The following files were skipped due to too many changes: yarn.lock, kleros-sdk/src/graphql/graphql.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago

Walkthrough

The pull request introduces several changes across the kleros-sdk project, including updates to the .gitignore file, modifications in JSON configuration for dispute templates, and significant alterations in the package.json. Import paths have been standardized using a tilde prefix, enhancing module resolution. Various TypeScript types have been added or modified, particularly concerning data mappings and validation mechanisms. Additionally, new TypeScript files for GraphQL utilities have been created, and existing configuration files have been updated to reflect changes in compiler options and module systems.

Changes

File Path Change Summary
kleros-sdk/.gitignore Updated to ignore lib, dist, and node_modules directories.
kleros-sdk/config/v2-disputetemplate/reality/example3/DisputeTemplate.json.mustache Updated arbitratorChainID from "421613" to "421614".
kleros-sdk/package.json Updated version to 2.0.1-3, changed main entry to ./lib/src/index.js, added types and module entries, restructured repository, added files and publishConfig fields, and modified scripts.
kleros-sdk/src/dataMappings/actions/callAction.ts Updated import paths for AbiCallMapping, createResultObject, and SDK functions to use a tilde prefix.
kleros-sdk/src/dataMappings/actions/eventAction.ts Updated import paths for AbiEventMapping, createResultObject, and SDK functions to use a tilde prefix.
kleros-sdk/src/dataMappings/actions/fetchIpfsJsonAction.ts Updated import paths for FetchIpfsJsonMapping, createResultObject, and MAX_BYTE_SIZE to use a tilde prefix.
kleros-sdk/src/dataMappings/actions/jsonAction.ts Updated import paths for JsonMapping and createResultObject to use a tilde prefix.
kleros-sdk/src/dataMappings/actions/subgraphAction.ts Updated import paths for SubgraphMapping and createResultObject to use a tilde prefix.
kleros-sdk/src/dataMappings/decoder.ts Updated import statements, simplified graphqlQueryFnHelper function signature, and modified genericDecoder logic to reflect changes in disputeTemplateRegistry.
kleros-sdk/src/dataMappings/executeActions.ts Updated method signatures to use DataMapping and DisputeRequest types, added validation for "reality" action type.
kleros-sdk/src/dataMappings/retrieveRealityData.ts Updated variable types from AbiEventMapping to DataMapping<AbiEventMapping>, and explicitly defined answers as an array of Answer objects.
kleros-sdk/src/dataMappings/utils/actionTypes.ts Deleted file containing several TypeScript type definitions related to mapping structures.
kleros-sdk/src/dataMappings/utils/dataMappingTypes.ts Introduced new types JsonMapping, AbiCallMapping, and RealityMapping, modified AbiEventMapping, and added DataMapping type.
kleros-sdk/src/dataMappings/utils/dataMappingValidators.ts Updated validation functions to accept DataMapping type instead of ActionMapping.
kleros-sdk/src/dataMappings/utils/disputeRequest.ts Introduced a new type definition DisputeRequest.
kleros-sdk/src/dataMappings/utils/populateTemplate.ts Updated import path for the validate function and added a comment regarding validation logic.
kleros-sdk/src/graphql/fragment-masking.ts Introduced utilities for handling GraphQL fragments, including FragmentType, useFragment, makeFragmentData, and isFragmentReady.
kleros-sdk/src/graphql/gql.ts Introduced a centralized mapping for GraphQL operations with a documents object and a graphql function for type-safe queries.
kleros-sdk/src/graphql/index.ts Re-exported all entities from fragment-masking and gql modules.
kleros-sdk/src/index.ts Re-exported all entities from the ./sdk module.
kleros-sdk/test/dataMappings.test.ts Updated import paths to use a tilde prefix, enhanced type safety in test cases, and modified assertions for mappings.
kleros-sdk/test/disputeDetailsSchema.test.ts Updated import path for disputeDetailsSchema to use a tilde prefix.
kleros-sdk/tsconfig-cjs.json Introduced a new TypeScript configuration file for CommonJS module system.
kleros-sdk/tsconfig.json Modified base configuration, updated output directory, and adjusted compiler options.
tsconfig/base.json Updated target, module, and moduleResolution properties, and added lib property.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SDK
    participant GraphQL
    User->>SDK: Initiate Action
    SDK->>GraphQL: Fetch Data
    GraphQL-->>SDK: Return Data
    SDK-->>User: Return Result

Possibly related PRs

Suggested reviewers

Poem

🐰 In the meadow where changes bloom,
A new path for our code to zoom.
With types so clear and imports bright,
Kleros SDK takes a flight!
From disputes to actions, all in sync,
Hop along, let’s make it link! 🌼


πŸͺ§ Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` or `@coderabbitai title` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
netlify[bot] commented 1 month ago

Deploy Preview for kleros-v2-university failed. Why did it fail? β†’

Name Link
Latest commit 4e9ad51277ea0c691585b21f07bd2ca0afeb3cb0
Latest deploy log https://app.netlify.com/sites/kleros-v2-university/deploys/67055c9924850d000804f7ca
netlify[bot] commented 1 month ago

Deploy Preview for kleros-v2-testnet failed. Why did it fail? β†’

Name Link
Latest commit 4e9ad51277ea0c691585b21f07bd2ca0afeb3cb0
Latest deploy log https://app.netlify.com/sites/kleros-v2-testnet/deploys/67055c99c71bf10009b465a1
netlify[bot] commented 1 month ago

Deploy Preview for kleros-v2-neo failed. Why did it fail? β†’

Name Link
Latest commit 4e9ad51277ea0c691585b21f07bd2ca0afeb3cb0
Latest deploy log https://app.netlify.com/sites/kleros-v2-neo/deploys/67055c996f359400081850da
codeclimate[bot] commented 1 month ago

Code Climate has analyzed commit 4e9ad512 and detected 804 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1
Duplication 206
Style 597

View more on Code Climate.

jaybuidl commented 1 month ago

Too old, superseded by #1703