Renamed DisputeRequest._arbitrableDisputeID into _arbitratorDisputeID

jaybuidl commented 1 month ago

The DisputeResolvers have been redeployed.

The subgraphs are not impacted because the DisputeRequest event is not indexed, the frontends are querying it directly from the logs.

Summary by CodeRabbit

New Features
- Updated deployment addresses for key smart contracts across various networks, enhancing clarity and accessibility for users.
Bug Fixes
- Renamed parameters in events and functions to improve consistency and understanding, particularly changing _arbitrableDisputeID to _arbitratorDisputeID.
Documentation
- Updated README files and metadata sections to reflect new contract addresses and changes in the Solidity compiler version.
Chores
- Incremented deployment counts and updated implementation addresses in the DisputeTemplateRegistry.

PR-Codex overview

This PR focuses on renaming variables and updating related references for clarity in the context of dispute handling within the arbitration system.

Detailed summary

Renamed _arbitrableDisputeID to _arbitratorDisputeID in multiple files.
Updated function parameters and event arguments accordingly.
Changed UI references in page.tsx for consistency.
Modified Solidity event documentation to reflect new naming.
Updated deployment JSON files for new implementation addresses.

The following files were skipped due to too many changes: contracts/deployments/arbitrumSepoliaDevnet/DisputeTemplateRegistry_Implementation.json, contracts/deployments/arbitrum/DisputeResolverNeo.json, contracts/deployments/arbitrumSepoliaDevnet/DisputeResolverNeo.json, contracts/deployments/arbitrumSepoliaDevnet/DisputeResolver.json, contracts/deployments/arbitrumSepoliaDevnet/DisputeResolverUniversity.json, contracts/deployments/arbitrumSepoliaDevnet/DisputeResolverRuler.json, contracts/deployments/arbitrumSepoliaDevnet/ArbitrableExample.json

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

coderabbitai[bot] commented 1 month ago

Walkthrough

The pull request includes significant updates across several smart contract files and related documentation. Key changes involve updating contract addresses for various dispute-related contracts, renaming parameters from _arbitrableDisputeID to _arbitratorDisputeID, and modifying transaction details such as hashes and block numbers. Additionally, the Solidity compiler version has been upgraded across multiple files, reflecting changes in metadata and ABI structures. These updates enhance clarity and ensure alignment with the latest deployment configurations.

Changes

File Path	Change Summary
contracts/README.md	Updated deployment addresses for `DisputeResolverNeo`, `DisputeResolver`, `DisputeTemplateRegistry`, and `ArbitrableExample`.
contracts/deployments/arbitrum/DisputeResolverNeo.json	Updated contract address, transaction hash, block number, and ABI parameter name from `_arbitrableDisputeID` to `_arbitratorDisputeID`. Updated compiler version from `0.8.18` to `0.8.24`.
contracts/deployments/arbitrumSepoliaDevnet/DisputeResolver.json	Updated contract address, transaction hash, and renamed parameters in ABI from `_arbitrableDisputeID` to `_arbitratorDisputeID`. Updated compiler version from `0.8.18` to `0.8.24`.
contracts/deployments/arbitrumSepoliaDevnet/DisputeResolverNeo.json	Updated contract address, transaction hash, and renamed parameters in ABI from `_arbitrableDisputeID` to `_arbitratorDisputeID`. Updated compiler version from `0.8.18` to `0.8.24`.
contracts/deployments/arbitrumSepoliaDevnet/DisputeResolverRuler.json	Updated contract address, transaction hash, and renamed parameters in ABI from `_arbitrableDisputeID` to `_arbitratorDisputeID`. Updated gas usage metrics and compiler version from `0.8.18` to `0.8.24`.
contracts/deployments/arbitrumSepoliaDevnet/DisputeResolverUniversity.json	Updated contract address, transaction hash, and renamed parameters in ABI from `_arbitrableDisputeID` to `_arbitratorDisputeID`. Updated compiler version from `0.8.18` to `0.8.24`.
contracts/deployments/arbitrumSepoliaDevnet/DisputeTemplateRegistry.json	Updated `implementation` address and incremented `numDeployments` from 1 to 2.
contracts/deployments/arbitrumSepoliaDevnet/DisputeTemplateRegistry_Implementation.json	Updated contract address, transaction hash, incremented `numDeployments` from 1 to 2, and updated compiler version from `0.8.18` to `0.8.24`.
contracts/src/arbitration/interfaces/IArbitrableV2.sol	Renamed parameters in `DisputeRequest` and `Ruling` events from `_arbitrableDisputeID` to `_arbitratorDisputeID`.
contracts/test/evidence/index.ts	Renamed variable in the `Moderation` section from `arbitrableDisputeID` to `arbitratorDisputeID`.
web-devtools/src/app/(main)/dispute-template/page.tsx	Renamed parameter in `params` state object from `_arbitrableDisputeID` to `_arbitratorDisputeID`.
web/src/hooks/queries/useEvidenceGroup.ts	Renamed parameter in `createEventFilter` method from `_arbitrableDisputeID` to `_arbitratorDisputeID`.
web/src/hooks/queries/usePopulatedDisputeData.ts	Renamed parameter in `getTemplateId` function from `_arbitrableDisputeID` to `_arbitratorDisputeID`.

Suggested labels

Type: Maintenance :construction:, Package: Web

Suggested reviewers

alcercu
kemuru
Harman-singh-waraich

Poem

🐰 In the land of code where disputes arise,
New names for IDs, oh what a surprise!
From arbitrable to arbitrator, we cheer,
Clearer paths for contracts, let’s give a big cheer!
With addresses updated, our work is well done,
In the world of blockchain, we’ve just begun! 🌟

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` or `@coderabbitai title` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

netlify[bot] commented 1 month ago

Deploy Preview for kleros-v2-testnet-devtools ready!

Name	Link
Latest commit	20e0d67845d72c6501107c5d807102bbc4dfef6f
Latest deploy log	https://app.netlify.com/sites/kleros-v2-testnet-devtools/deploys/670e9974f3276c0008218fa0
Deploy Preview	https://deploy-preview-1711--kleros-v2-testnet-devtools.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 month ago

Deploy Preview for kleros-v2-university failed. Why did it fail? →

Name	Link
Latest commit	20e0d67845d72c6501107c5d807102bbc4dfef6f
Latest deploy log	https://app.netlify.com/sites/kleros-v2-university/deploys/670e9974e4c50800085f1ae4

netlify[bot] commented 1 month ago

Deploy Preview for kleros-v2-testnet ready!

Name	Link
Latest commit	20e0d67845d72c6501107c5d807102bbc4dfef6f
Latest deploy log	https://app.netlify.com/sites/kleros-v2-testnet/deploys/670e9974c349390008cb72a4
Deploy Preview	https://deploy-preview-1711--kleros-v2-testnet.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 month ago

Deploy Preview for kleros-v2-neo ready!

Name	Link
Latest commit	20e0d67845d72c6501107c5d807102bbc4dfef6f
Latest deploy log	https://app.netlify.com/sites/kleros-v2-neo/deploys/670e9974a05673000885fcff
Deploy Preview	https://deploy-preview-1711--kleros-v2-neo.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.