search

kleros / stake-curate

Curate with indefinite, capital-efficient stake.
8 stars 3 forks source link

refactor: remove contribution and appeal logic #12

Closed kemuru closed 2 years ago

kemuru commented 2 years ago

closes #9

greenlucid commented 2 years ago

Tests are now broken. You should fix them. Take into account that these tests (negligently, sorry) are interdependent. You should use something like beforeEach to isolate unit tests. Whether if you want this beforeEach called before each unit test, or before bundles of unit tests (e.g. accounts, lists), it's up to you.

greenlucid commented 2 years ago

Actually, please remove DisputeFailed and DisputeSuccessful events, they aren't needed (the subgraph can tell the result of the dispute by reading Ruling and checking disputeIdToDisputeSlot That way you can remove some complexity off the tests

greenlucid commented 2 years ago

The tests are still interdependent, but they work, LGTM