search

kleros / stake-curate

Curate with indefinite, capital-efficient stake.
8 stars 3 forks source link

timestamps are unsafe for a few things #26

Closed greenlucid closed 2 years ago

greenlucid commented 2 years ago

Timestamps should be replaced by block numbers as much as possible. For example, making the id of an item (itemSlot + block) to make it truly an unique id. Also, timestamp period should be changed to an amount of blocks, and it shouldn't be immutable.

greenlucid commented 2 years ago

Also, timestamp period should be changed to an amount of blocks, and it shouldn't be immutable.

I was wrong about this. submissionTimestamp (now submissionBlock) is only used to generate "identity", e.g. the evidenceGroupId. Nothing else. So, so far, it could be reasonable to continue having a constant withdrawal period of one week.