search

kleros / vea

Vea bridge
https://vea.ninja
MIT License
9 stars 6 forks source link

Testnet preparation, migration to Sepolia, solc 0.8.24, node 18, yarn 4 #273

Closed jaybuidl closed 1 month ago

jaybuidl commented 8 months ago

PR-Codex overview

This PR updates Solidity versions and refactors contracts for Arbitrum Sepolia deployment. It also adjusts network configurations and dependencies.

Detailed summary

The following files were skipped due to too many changes: contracts/src/test/bridge-mocks/arbitrum/InboxMock.sol, contracts/src/test/bridge-mocks/arbitrum/SequencerInboxMock.sol, contracts/test/merkle/index.ts, contracts/src/test/bridge-mocks/arbitrum/BridgeMock.sol, contracts/src/canonical/polygon/FxBaseRootTunnel.sol, contracts/src/utils/veaInboxTouch.sol, relayer-subgraph-inbox/package.json, relayer-subgraph-inbox/subgraph.yaml, veascan-subgraph-outbox/subgraph.yaml, contracts/src/canonical/arbitrum/ISequencerInbox.sol, contracts/src/utils/L1/veaOutboxMultiChallenge.sol, veascan-subgraph-outbox/README.md, veascan-subgraph-inbox/subgraph.yaml, services/graph-node/docker-compose.yml, validator-cli/src/devnet/arbToChiado/happyPath.ts, veascan-subgraph-inbox/src/VeaInbox.ts, contracts/src/interfaces/updaters/ISequencerDelayUpdatable.sol, contracts/src/interfaces/updaters/ISequencerFutureUpdatable.sol, contracts/src/utils/L1/veaOutboxMultiChallengeWETH.sol, validator-cli/.env.dist, validator-cli/src/devnet/arbToGoerli/happyPath.ts, relayer-cli/.env.dist, veascan-subgraph-outbox/package.json, contracts/src/canonical/arbitrum/AddressAliasHelper.sol, relayer-subgraph-inbox/src/vea-inbox-arb-to-eth.ts, contracts/src/interfaces/routers/IRouterToL1.sol, contracts/deploy/02-inbox/02-arb-goerli-to-chiado-inbox.ts, contracts/src/interfaces/routers/IRouterToArb.sol, contracts/src/canonical/arbitrum/IInbox.sol, veascan-subgraph-outbox/src/VeaOutbox.ts, veascan-web/src/consts/bridges.ts, contracts/deploy/02-inbox/02-chiado-to-arb-sepolia-inbox.ts, contracts/deploy/02-inbox/02-arb-goerli-to-goerli-inbox.ts, relayer-cli/src/utils/proof.ts, validator-cli/src/utils/devnet.ts, contracts/deploy/02-inbox/02-gnosis-to-arb-inbox.ts, contracts/deploy/03-routers/03-arb-goerli-to-chiado-router.ts, contracts/deploy/02-inbox/02-arb-to-eth-inbox.ts, contracts/src/test/ArbitrumToEth/VeaOutboxMockArbToEth.sol, contracts/hardhat.config.ts, validator-cli/src/utils/ethers.ts, contracts/deploy/02-inbox/02-arb-to-gnosis-inbox.ts, relayer-cli/src/devnetRelayExample.ts, contracts/src/interfaces/tokens/gnosis/IWETH.sol, contracts/README.md, contracts/deploy/03-routers/03-chiado-to-arb-sepolia-router.ts, relayer-cli/src/utils/relay.ts, contracts/deploy/03-routers/03-arb-to-gnosis-router.ts, contracts/deploy/01-outbox/01-arb-goerli-to-goerli-outbox.ts, contracts/deploy/03-routers/03-gnosis-to-arb-router.ts, contracts/package.json, contracts/deploy/01-outbox/01-arb-goerli-to-chiado-outbox.ts, contracts/deploy/01-outbox/01-chiado-to-arb-sepolia-outbox.ts, contracts/deploy/01-outbox/01-gnosis-to-arb-outbox.ts, contracts/src/devnets/gnosisToArbitrum/VeaOutboxGnosisToArbDevnet.sol, contracts/deploy/01-outbox/01-arb-to-gnosis-outbox.ts, contracts/src/arbitrumToEth/VeaInboxArbToEth.sol, contracts/deploy/01-outbox/01-arb-to-eth-outbox.ts, contracts/src/devnets/arbitrumToEth/VeaOutboxArbToEthDevnet.sol, contracts/src/arbitrumToGnosis/VeaInboxArbToGnosis.sol, contracts/src/arbitrumToGnosis/RouterArbToGnosis.sol, validator-cli/src/ArbToEth/watcher.ts, contracts/src/devnets/arbitrumToGnosis/VeaOutboxArbToGnosisDevnet.sol, contracts/src/gnosisToArbitrum/VeaInboxGnosisToArb.sol, contracts/src/gnosisToArbitrum/RouterGnosisToArb.sol, yarn.lock, contracts/src/gnosisToArbitrum/VeaOutboxGnosisToArb.sol, contracts/src/arbitrumToEth/VeaOutboxArbToEth.sol, contracts/src/arbitrumToGnosis/VeaOutboxArbToGnosis.sol, validator-cli/src/ArbToEth/watcherArbToEth.ts, validator-cli/src/ArbToEth/watcherArbToGnosis.ts, contracts/test/integration/ArbToEth.ts, contracts/deployments/arbitrumGoerli/VeaInboxArbToEthTestnet.json, contracts/deployments/arbitrumSepolia/VeaInboxArbToEthDevnet.json, contracts/deployments/arbitrumGoerli/VeaInboxArbToGnosisTestnet.json, contracts/deployments/chiado/VeaInboxGnosisToArbDevnet.json, contracts/deployments/chiado/VeaInboxGnosisToArbTestnet.json, contracts/deployments/goerli/RouterArbToGnosisTestnet.json, contracts/deployments/goerli/RouterArbToGnosisDevnet.json, contracts/deployments/arbitrumGoerli/VeaInboxArbToEthDevnet.json, contracts/deployments/arbitrumGoerli/VeaInboxArbToGnosisDevnet.json, contracts/deployments/goerli/RouterGnosisToArbDevnet.json, contracts/deployments/goerli/RouterGnosisToArbTestnet.json, contracts/deployments/arbitrumGoerli/VeaOutboxGnosisToArbTestnet.json, contracts/deployments/arbitrumGoerli/VeaOutboxGnosisToArbDevnet.json, contracts/deployments/goerli/VeaOutboxArbToEthTestnet.json, contracts/deployments/chiado/VeaOutboxArbToGnosisTestnet.json, contracts/deployments/sepolia/VeaOutboxArbToEthDevnet.json, contracts/deployments/goerli/VeaOutboxArbToEthDevnet.json, contracts/deployments/chiado/VeaOutboxArbToGnosisDevnet.json

āœØ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

netlify[bot] commented 8 months ago

Deploy Preview for veascan failed.

Name Link
Latest commit ff5db2c3b08f337012a0d6792d0078f4292271fe
Latest deploy log https://app.netlify.com/sites/veascan/deploys/6536cfdd945d6e0008df70f9
netlify[bot] commented 1 month ago

Deploy Preview for veascan failed. Why did it fail? ā†’

Name Link
Latest commit d9107c42a1a2e25c54a44bc21ec9645492e98b1c
Latest deploy log https://app.netlify.com/sites/veascan/deploys/6660c6e6847775000810cb3c
coderabbitai[bot] commented 1 month ago

Walkthrough

The recent updates transition the development environment from Goerli to Sepolia, involving renaming environments and updating contract addresses. Deployment scripts and verification processes have been adjusted to reflect these changes, alongside parameter modifications for various chains to enhance functionality and adaptability.

Changes

Files Change Summary
contracts/README.md Renamed environments from Goerli to Sepolia and updated contract addresses accordingly.
contracts/deploy/01-outbox/... Adjusted parameters for different chains, including deposit amounts, epoch periods, and introduced new parameters. Updated deployment tags and logic.
contracts/deploy/02-inbox/... Renamed enum values, adjusted epoch period values, removed execute function usage, and updated deployment logic and tags.
contracts/hardhat.config.ts Updated Solidity version, network configurations, and added API URLs for different networks.

Sequence Diagram(s) (Beta)

sequenceDiagram
    participant Dev as Developer
    participant Env as Environment
    participant Contract as Contract
    participant Verifier as Verifier

    Dev->>Env: Rename Goerli to Sepolia
    Env->>Contract: Update contract addresses
    Dev->>Env: Adjust deployment scripts
    Env->>Contract: Deploy with new parameters
    Contract->>Verifier: Verify new deployments

Poem

In codes of Sepolia, we now dwell,
From Goerli's shores, we bid farewell.
Contracts shift, addresses align,
Deployment scripts in perfect line.
With parameters set and tags anew,
A blockchain journey we pursue.
šŸ‡āœØ

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
jaybuidl commented 1 month ago

@coderabbitai full review

coderabbitai[bot] commented 1 month ago
Actions performed Full review triggered.