klesun / deep-assoc-completion

A phpstorm plugin for associative array key typing and completion
Other
267 stars 17 forks source link

ignore the string starts with underscore. #169

Closed manaphp closed 3 years ago

manaphp commented 3 years ago

can we ignore the string start with underscore.? 20201119113246

manaphp commented 3 years ago

https://github.com/klesun/deep-assoc-completion/issues/143#issue-554552548

klesun commented 3 years ago

Hi. In general case no, but maybe some annotation like @noDeepAssoc or something could be added on the properties you want to exclude, or something.

klesun commented 3 years ago

Actually, are _snapshot and _last_refresh private fields per chance, while others are protected? I take it you get this completion from get_object_vars() in the scope where these private fields are not accessible, maybe that could be considered in the plugin...

klesun commented 3 years ago

image

manaphp commented 3 years ago

i change from protected to private, but it does't effect...

manaphp commented 3 years ago

Hi. In general case no, but maybe some annotation like @noDeepAssoc or something could be added on the properties you want to exclude, or something.

supported now?!

klesun commented 3 years ago

No, not supported, would need to implement, I'm just throwing options of how it could be done.

manaphp commented 3 years ago

No, not supported, would need to implement, I'm just throwing options of how it could be done.

array_diff_assoc(get_class_vars(new static),['_last_refresh'=>1])

don't work..

if can work, it is boring also.

klesun commented 3 years ago

Sorry, realistically speaking, I'll probably won't have time to implement this feature, since I've even been ignoring bugs and typing issues for months. I do intend to dedicate small part of my time to deep-assoc, but it will be barely enough for others, more impactful issues.

klesun commented 3 years ago

Actually, wasn't it same thing as https://github.com/klesun/deep-assoc-completion/issues/120 ?