search

kleveross / klever-model-registry

Cloud Native Machine Learning Model Registry
https://kleveross.github.io/klever-model-registry/api/
Apache License 2.0
80 stars 25 forks source link

fix(serving): fix bug of serving userContainer's image and env #237

Closed songzhiwei7 closed 3 years ago

songzhiwei7 commented 3 years ago

What type of PR is this?

/kind bug /area serving

What this PR does / why we need it:

  1. run failed because the old_model_path is undefined
  2. no need to set the default env when container is custom

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #

Reference to #

Special notes for your reviewer:

/cc @your-reviewer

Does this PR introduce a user-facing change?:

fix bug of serving userContainer's image and env
simon-cj commented 3 years ago

/lgtm

caicloud-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simon-cj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kleveross/klever-model-registry/blob/master/OWNERS)~~ [simon-cj] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment