Closed gbolmier closed 2 years ago
Thanks for the issue. I will try to fix it ASAP
We may migrate to https://github.com/oras-project/oras-py in the near future. Maybe I do not have the bandwidth for it.
Thus /help-wanted
Thanks for the update @gaocegege 👍
/kind bug
What happened:
pip
installingormb
Python SDK installed Linux binaries on my Mac OS machine.What you expected to happen:
I would expect Darwin binaries instead.
How to reproduce it (as minimally and precisely as possible):
Run
pip install ormb
on a mac, then try anyormb
command in a Python interpreter, e.g.:or in a terminal using the installed pre-compiled binaries path:
Here is the executable file type:
Anything else we need to know?:
It doesn't look like the problem comes from
extern-sdk/python/git_release.py
.On my system:
Therefore, the following loop:
https://github.com/kleveross/ormb/blob/980a50629afc81960e02a0cc4aacf6e75c068263/extern-sdk/python/git_release.py#L33-L37
should give to
asset_name
the following value'ormb_0.0.11_Darwin_i386.tar.gz'
, which doesn't exist in the releases afterv0.0.9
, I guess it automatically falls back on'ormb_0.0.11_Linux_x86_64.tar.gz'
?