search

kleveross / ormb

Docker for Your ML/DL Models Based on OCI Artifacts
Apache License 2.0
461 stars 61 forks source link

[python-sdk] Remove requests dependency #198

Closed gbolmier closed 2 years ago

gbolmier commented 2 years ago

What type of PR is this?

/kind bug /kind dependency

What this PR does / why we need it:

It replaces requests dependency with urllib.request from the python standard library in git_release.py (called by setup.py) in the python sdk. We need to get rid of the requests dependency to fix the setup.py bug that calls the requests package before installing it.

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #195

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
gbolmier commented 2 years ago

Tested both locally and from the branch:

pip install git+https://git@github.com/gbolmier/ormb.git@hotfix/python-sdk/remove-requests-dependency#subdirectory=extern-sdk/python

works as a charm on my side 🚀