Migrate to distribution/reference

sel commented 1 year ago

What type of PR is this?

/kind bug /area cli

What this PR does / why we need it:

Use the tried and tested package github.com/docker/distribution/reference for parsing OCI references.

Which issue(s) this PR is related to:

Fixes #209

Special notes for your reviewer:

This patch uses the already-vendored package github.com/docker/distribution/reference. When the dependencies are upgraded we should switch to the CNCF-contributed package, which was factored out of the docker one and keeps the same API: github.com/distribution/reference
I chose to keep the existing Reference API in ormb's oci package as a facade instead of updating all call-sites to use github.com/docker/distribution/reference. If you prefer I am open to doing the latter also.
The distribution/reference package has extensive tests so I only added a few here to regression-test the specific bug fixed by this change.

/cc @gaocegege

Does this PR introduce a user-facing change?:

NONE

markhulia commented 10 months ago

@gaocegege could you please merge this PR?

gaocegege commented 10 months ago

CI blocks the automatic merge. I am merging it manually.

sel commented 7 months ago

@gaocegege could you please make a new release in GitHub? The ormb binary in the Python SDK is outdated.

kleveross / ormb