search

kleydon / prisma-session-store

Express session store for Prisma
MIT License
116 stars 18 forks source link

fix: issue 91 by changing 'delete' to 'deleteMany' and updating tests #102

Closed geefuoco closed 1 year ago

geefuoco commented 1 year ago

I updated the destroy function to use deleteMany instead of delete. Since it is using a unique id, it will only ever delete at most 1 session.

I also updated the tests to reflect that change

kleydon commented 1 year ago

Hi @geefuoco - really appreciate the help!

Reviewing the PR now...

kleydon commented 1 year ago

Looks like this is not yet passing the lint checks. (Running yarn run lint should reveal them...)

kleydon commented 1 year ago

@geefuoco - Found a couple of minor things I'm hoping you might be willing to address, but - clearly an improvement people will appreciate. Thanks again.

geefuoco commented 1 year ago

I will have a look and see if I can fix. Thanks

kleydon commented 1 year ago

:tada: This PR is included in version 3.1.9 :tada:

The release is available on:

Your semantic-release bot :package::rocket: