Closed wSedlacek closed 2 years ago
@kleydon Let's hold off on merging this until we have confirmed the results of the requested test of https://github.com/kleydon/prisma-session-store/issues/62#issuecomment-955767459
👍
Any news on that? It's getting tricky to upgrade to Prisma 3 when using prisma-session-store
.
Hi @wSedlacek,
Let's hold off on merging this until we have confirmed the results of the requested test of #62 (comment)
Do you still see value in waiting? (I'm weighing whether to merge this, vs. create another PR & release that moves prisma to a dev dependency...)
-K
It's been enough time, let's get this merged in.
@wSedlacek - Merged this PR ~5min ago, but am forgetting: Should merging have automatically generated a new release / npm package version? Or are additional steps necessary? Thanks, -K
The release will only occur if there are feat
or fix
commits.
Since this was a chore
no release occurred.
@wSedlacek - To attempt to trigger a new release, I've:
1) Created a fix commit on a new branch (the commit content being trivial changes to the README) 2) Merge the new branch into master.
So far, though, it looks like no new release / package version has been triggered.
Any recommendations re: what to do differently, how to diagnose, or how to 'manually' kick off a release / NPM update?
The most recent release failed because the commit failed to pass commitlint: https://github.com/kleydon/prisma-session-store/runs/4434580829?check_suite_focus=true
✖ footer's lines must not be longer than 100 characters [footer-max-line-length]
I recommend making another PR to change this setting from a error
to a warning
so that the generated commits do not fail because of it.
Thanks!
:tada: This PR is included in version 3.1.1 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
@simontaisne
Any news on that? It's getting tricky to upgrade to Prisma 3 when using prisma-session-store.
Just updated the npm package; things should be fixed now...
Awesome! Thanks for the new release 💯
👍
Description
This updates the dependencies and dev dependencies to the latest version at time of writing This updates husky to the new format introduced in husky 7 This moves
prisma
from being a dependency to a devDependency as@prisma/client
is already a peerDependency This configurests-jest
to explicitly use thetsconfig.spec.json
This configures testing to allowes2019
so thatObject.fromEntries
can be used. This updates the GitHub Actions to run with node 14.x