kleydon / prisma-session-store

Express session store for Prisma
MIT License
116 stars 18 forks source link

chore: update dependencies #63

Closed wSedlacek closed 2 years ago

wSedlacek commented 2 years ago

Description

This updates the dependencies and dev dependencies to the latest version at time of writing This updates husky to the new format introduced in husky 7 This moves prisma from being a dependency to a devDependency as @prisma/client is already a peerDependency This configures ts-jest to explicitly use the tsconfig.spec.json This configures testing to allow es2019 so that Object.fromEntries can be used. This updates the GitHub Actions to run with node 14.x

wSedlacek commented 2 years ago

@kleydon Let's hold off on merging this until we have confirmed the results of the requested test of https://github.com/kleydon/prisma-session-store/issues/62#issuecomment-955767459

kleydon commented 2 years ago

👍

simontaisne commented 2 years ago

Any news on that? It's getting tricky to upgrade to Prisma 3 when using prisma-session-store.

kleydon commented 2 years ago

Hi @wSedlacek,

Let's hold off on merging this until we have confirmed the results of the requested test of #62 (comment)

Do you still see value in waiting? (I'm weighing whether to merge this, vs. create another PR & release that moves prisma to a dev dependency...)

-K

wSedlacek commented 2 years ago

It's been enough time, let's get this merged in.

kleydon commented 2 years ago

@wSedlacek - Merged this PR ~5min ago, but am forgetting: Should merging have automatically generated a new release / npm package version? Or are additional steps necessary? Thanks, -K

wSedlacek commented 2 years ago

The release will only occur if there are feat or fix commits. Since this was a chore no release occurred.

kleydon commented 2 years ago

@wSedlacek - To attempt to trigger a new release, I've:

1) Created a fix commit on a new branch (the commit content being trivial changes to the README) 2) Merge the new branch into master.

So far, though, it looks like no new release / package version has been triggered.

Any recommendations re: what to do differently, how to diagnose, or how to 'manually' kick off a release / NPM update?

wSedlacek commented 2 years ago

The most recent release failed because the commit failed to pass commitlint: https://github.com/kleydon/prisma-session-store/runs/4434580829?check_suite_focus=true

✖   footer's lines must not be longer than 100 characters [footer-max-line-length]

https://github.com/conventional-changelog/commitlint/blob/e7a6a7ac1b2179b3c1896957b4a6c4c0b68ec6f4/%40commitlint/config-conventional/index.js#L8

I recommend making another PR to change this setting from a error to a warning so that the generated commits do not fail because of it.

kleydon commented 2 years ago

Thanks!

kleydon commented 2 years ago

:tada: This PR is included in version 3.1.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

kleydon commented 2 years ago

@simontaisne

Any news on that? It's getting tricky to upgrade to Prisma 3 when using prisma-session-store.

Just updated the npm package; things should be fixed now...

simontaisne commented 2 years ago

Awesome! Thanks for the new release 💯

kleydon commented 2 years ago

👍