search

klikli-dev / modonomicon

Data-driven minecraft in-game documentation with progress visualization.
22 stars 9 forks source link

Certain offsets between entries draw the connection lines wrongly #185

Closed DaFuqs closed 3 months ago

DaFuqs commented 3 months ago

Describe the bug With certain offsets between entries, some parts of the line is drawn at a wrong position.

To Reproduce Steps to reproduce the behavior:

  1. Create entry1 at pos x:0, y:0
  2. Create entry2 at pos x:3, y:-1
  3. In entry2, set entry1 as parent, including "line_reversed": true
  4. Join game
  5. look at the category with those two entries
  6. See error (screenshot below)

Expected behavior Arrow and line being drawn correctly

Screenshots image

System (please complete the following information):

klikli-dev commented 3 months ago

ok so fun fact, due to me not having thought about the connection render logic for ages I just asked copilot to compare reversed vs non reversed and fix reversed .. and I think it did fix it. Please let me know if all connections work for you after that change - in the demo book it looks good

DaFuqs commented 3 months ago

Looks perfect now, thx!