search

klikli-dev / occultism

A magic mod inspired by the world of Jonathan Stroud's Bartimaeus. With the help of occult rituals players can summon entities from the "Other Side" to perform magic.
https://www.curseforge.com/minecraft/mc-mods/occultism
MIT License
67 stars 43 forks source link

Dimensional mineshafts don't allow Djinni miners #1107

Closed theCalcaholic closed 2 months ago

theCalcaholic commented 2 months ago

Describe the bug So if I understand how they should work, dimensional mineshafts are broken for me in two ways:

  1. They don't produce ores. The progress bar will complete multiple times, but they won't output anything. Similar to #892 but without the broken recipes in JEI/REI (and on the latest version of Occultism). Also the durability of the ore miner doesn't reduce.
  2. I cannot input the ore miners by hand, only with a hopper. When I drag a lamp into the slot, it won't allow me to drop it there, but putting a hopper on top of the mineshaft and inserting ore miners through that works.

To Reproduce Steps to reproduce the behavior:

  1. Place dimensional mineshaft
  2. Right click and fail to insert ore miner by hand
  3. Add hopper on top and insert ore miner through that
  4. Observer no ores getting produced.

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

System (please complete the following information):

Additional context

EDIT: I just noticed, that this behavior does only apply to Djinni miners for some reason - which are the only ones I had tried so far. Foliots, Afrits and Marids do work as expected. Am I missing something?

klikli-dev commented 2 months ago

The behaviour your describe indicates a recipe issue (I think hoppers bypass the "insert only if valid recipe" check). Do you see any recipes for djinni miners?

theCalcaholic commented 2 months ago

@klikli-dev Interesting, I just noticed, that, according to REI, the Djinni ore miner has no tags, which sounds like it could be the issue - any idea what might cause this?

I suppose the mineshaft isn't accepting it, because it's missing the #occultism:miners/ores tag.

GaeaKat commented 2 months ago

Looked into this, it looks like it may have been missed when I added data-gen for tags