search

klikli-dev / occultism

A magic mod inspired by the world of Jonathan Stroud's Bartimaeus. With the help of occult rituals players can summon entities from the "Other Side" to perform magic.
https://www.curseforge.com/minecraft/mc-mods/occultism
MIT License
67 stars 43 forks source link

Dimensional Mineshaft could produce minecraft:barrier items #1129

Closed YocyCraft closed 2 weeks ago

YocyCraft commented 2 weeks ago

Describe the bug As the title

To Reproduce Steps to reproduce the behavior:

  1. Place block 'Dimensional Mineshaft'
  2. Put a Miner in it
  3. It will produce barrier item occasionally

Expected behavior Dimensional Mineshaft should not produce minecraft:barrier items

Screenshots 2024-06-20_02 59 25 2024-06-20_02 59 31

System (please complete the following information):

Additional context

ffuentesm commented 2 weeks ago

Oh, I think that is because it is generating an item from a tag that does not exist, so it defaults to the barrier block.

In the image's case, it was generating an Aluminium Ore, but since there is no aluminum ore mod, it outputs the barrier.

klikli-dev commented 2 weeks ago

This is a known issue related to kubejs and occultism interactions, but it seems it cannot be fixed. You can prevent it by running /reload If you join discord the FAQ channel has a small kubejs script to automatically fix this on each world load

YocyCraft commented 2 weeks ago

This is a known issue related to kubejs and occultism interactions, but it seems it cannot be fixed. You can prevent it by running /reload If you join discord the FAQ channel has a small kubejs script to automatically fix this on each world load

But kubejs is not in the modpack

ffuentesm commented 2 weeks ago

@YocyCraft is there any mod that adds blocks with those Ores tags? My understanding is that the Mineshaft is trying to generate that block, but since it's not available, it outputs a barrier. More Metals II adds aluminum, so I believe it would patch that problem at least.

klikli-dev commented 2 weeks ago

This is a known issue related to kubejs and occultism interactions, but it seems it cannot be fixed. You can prevent it by running /reload If you join discord the FAQ channel has a small kubejs script to automatically fix this on each world load

But kubejs is not in the modpack

That is a very important piece of info. So far we've only seen that with kubejs.

I have to investigate, it might be related to recipe conditions (namely, it's loading a recipe for an empty tag that it shouldn't.) I'll check!

klikli-dev commented 2 weeks ago

Recipe conditions were the culprit, should all be fixed now :)