klikli-dev / occultism

A magic mod inspired by the world of Jonathan Stroud's Bartimaeus. With the help of occult rituals players can summon entities from the "Other Side" to perform magic.
https://www.curseforge.com/minecraft/mc-mods/occultism
MIT License
74 stars 47 forks source link

Otherworld Treese don't drop proper logs when vein mined. #1230

Open dorn284 opened 5 days ago

dorn284 commented 5 days ago

Describe the bug When under the third eye effect, you can't "vein mine" the occult tree and get the correct wood. You get oak wood instead. Have used Tree Harvester mod, Ars Nouveau Fel tree spell, and Ultimine.

To Reproduce Steps to reproduce the behavior:

  1. Grow Otherworld tree
  2. Attempt to vein mine
  3. receive normal oak logs

Expected behavior I would expect to receive the other world logs.

System (please complete the following information):

Additional context Have eaten the demon dream fruit and the otherworld essence when trying to vein mine. Have not tried using the goggles yet.

klikli-dev commented 4 days ago

I am not sure if I can fix that on my end. The drop is determined based on the "playerDestroy" function of the block, and there it checks if the player has third eye effect to determine which block it represents (Oak as "hidden" state, or Otherworld wood if "visible")

Presumably the veinminer mods do not simulate this event on each destroyed block to save performance, which leads to Occultism not knowing that third eye is happening.

However, considering how old this mechanic is, it may now be possible to do the same with a loottable, which probably works with veinminers. I will look into that, if not we'll have to work with the veinminer mod makers to find a common solution

Eqis-Edu commented 4 days ago

I did some tests here, Forge - 47.3.0 and occultism-1.20.1-1.139.1.jar

Works fine

Don't work and put the wrong sapling

Strange reactions

The goggles don't matter, only visual

klikli-dev commented 4 days ago

That result is not too bad to be honest. Ars working with break is interesting because it means the tool is forwarded to the block, but not the player apparently maybe I don't know. But the pickaxe can harvest the logs even without the effect.