klikli-dev / occultism

A magic mod inspired by the world of Jonathan Stroud's Bartimaeus. With the help of occult rituals players can summon entities from the "Other Side" to perform magic.
https://www.curseforge.com/minecraft/mc-mods/occultism
MIT License
71 stars 43 forks source link

[1.18.1] iesnium can conditionally spawn in the overworld, visible to plain sight and mineable with a stone pickaxe #600

Closed esotericist closed 2 years ago

esotericist commented 2 years ago

Describe the bug iesnium can conditionally spawn in the overworld, visible to plain sight and mineable with a stone pickaxe

To Reproduce Steps to reproduce the behavior:

  1. have terralith installed (datapack based worldgen)
  2. find a biome with nether-based blocks (in this case, it was the 'yellowstone' biome, but i'm wondering if this could happen with the volcanos too)
  3. just happen to find exposed iesnium ore laying out in the open
  4. mine it with a stone (!!!) pickaxe
  5. profit! no ??? needed

Expected behavior i'm pretty sure i'm not supposed to find iesnium out in the overworld, and i'm pretty sure i'm not supposed to be able to mine it with a basic stone pickaxe

Screenshots https://cdn.discordapp.com/attachments/360995219321126935/922332569289232404/unknown.png

System (please complete the following information):

Additional context i'm pretty sure all you need to replicate this is terralith and occultism and a lot of luck, and that whole list of mods is probably unnecessary to reproduce

i also wouldn't be surprised if anything that uses similar nether blocks in the overworld as part of world generation could produce this result.

note that terralith is 100% datapack based, and thus not using forge hooks. this is effectively vanilla worldgen, which might potentially be part of the issue.

klikli-dev commented 2 years ago

Thanks for the report!

The underlying cause for the ore to spawn in the overworld is that it's not actually limited to the nether (I don't think minecraft even supports this without some hackery), but rather to nether blocks. So this part is OK.

The visible iesnium ore spawning reminds me of another 1.18 issue ( #584 ) where the wrong ore block was set up with worldgen. Could you test (using the divination rod) if proper "hidden" iesnium spawns in the nether? (ideally in a new world on your pack).

I suspect your generated world is either from before fixing that issue, or the datapack for terralith still has the jsons from before that fix.

esotericist commented 2 years ago

oh, i'm 100% certain that specific span of worldgen was from a few versions ago, because i ran a /forge generate out to a fair distance before i started playing.

so it seems likely this is a stale report, at least for the actionable part? i can try to look into the iesnium thing with the divination rod later.

klikli-dev commented 2 years ago

Thank you - then I'll close it for now, but if it pops up on a recent worldgen version please comment / ping me so I can reopen. The divination rod would be a nice touch, but in that case I'm 99.99% sure that it's just the old issue so it's not strictly necessary :)