klikli-dev / theurgy

An open-source magic mod built around classical alchemy to replicate and transmutate matter, and create magical artifacts.
https://www.curseforge.com/minecraft/mc-mods/theurgy
13 stars 8 forks source link

Most sulfurs appear to be missing #193

Closed MuteTiefling closed 2 months ago

MuteTiefling commented 2 months ago

Describe the bug Most sulfurs appear to be missing. For example, I only see Wheat Sulfur in EMI. The sulfurs for raw ores are all missing. They're also missing from the book:

Screenshots image

System (please complete the following information):

klikli-dev commented 2 months ago

Thanks for reporting! I have to investigate, it might have to do with recipe conditions and loading changes in 1.21

Weird is that it can still render the name which I think this page automatically takes from the item ..

klikli-dev commented 2 months ago

@MuteTiefling ok with "just" theurgy (my dev env) I cannot reproduce that, I can see all the vanilla-related sulfurs, both in JEI and in the book. Same if I additionally install EMI (book still works and the sulfurs show in EMI).

Could you attach a log? maybe that has some indicators

amahlaka commented 2 months ago

I just noticed the same issue, However, the sulfurs i have in my inventory such as iron and tin sulfurs are still there and render properly, but those don't show up in EMI.

And what is even weirder, is that the only item that i can insert into Liquefaction cauldron is Wheat, no other item is accepted when i right click it. Also cant insert items into any of the other basic blocks such as calcination oven

MuteTiefling commented 2 months ago

Yep, that's exactly how it presents for me.

Attached is a latest.log after launching the game. I've updated modonomicon as well from the initial report.

https://gist.github.com/MuteTiefling/5ca95d797e5787b83cd84c6d0bdeccd6

MuteTiefling commented 2 months ago

This is the only thing that sticks out at me: [01Jul2024 10:06:45.853] [Render thread/WARN] [Modonomicon/]: Recipe theurgy:calcination/alchemical_salt_strata_from_cobblestone (of type theurgy:calcination) not found.

Is the rest of it dependant on this salt? All I have for strata salts are from clay and gravel:

image

ImAK9 commented 2 months ago

For some very odd reason, entirely deleting the /kubejs folder fixes this issue.. image image

klikli-dev commented 2 months ago

Thanks for the investigation! This was a KubeJS issue, fixed in https://github.com/KubeJS-Mods/KubeJS/commit/b8970fd4bd867da594952042bd3bd91b265115b3

Because it requires changes to the condition itself I have to mirror their changes in my fluid tag condition. I will leave the issue open until I implemented this in such a way that I can access kubejs data without a hard dependency on kubejs

klikli-dev commented 2 months ago

Ok, going to add a temp fix for the fluid stuff and close this. Kubejs is working on a real solution for the issues related to tag modifications, if that needs theurgy changes too I will adopt them once available.