search

kliment / 4pi-firmware

18 stars 21 forks source link

Attribution #15

Closed simen closed 11 years ago

simen commented 11 years ago

Nice work! Looking forward to trying this out.

Since recognition is the main reward in the open source world, I think it would be nice if the planner and stepper modules retained some attribution back to the grbl project! (github.com/grbl/grbl)

kliment commented 11 years ago

On 05/16/2013 04:02 PM, Simen Svale Skogsrud wrote:

Nice work! Looking forward to trying this out.

Since recognition is the main reward in the open source world, I think it would be nice if the planner and stepper modules retained some attribution back to the grbl project! (github.com/grbl/grbl)

— Reply to this email directly or view it on GitHub https://github.com/kliment/4pi-firmware/issues/15.

Absolutely! I believe it's mentioned in the source. Would you like me to include a note in the readme? What would you like it to say?

simen commented 11 years ago

A mention in the readme would be nice, but mainly I think attribution has been lost from the source files. Something like "Originally from Grbl (github.com/grbl/grbl)" somewhere in the comment blocks on top of the .c and .h of the planner and stepper driver files is plenty good.

kliment commented 11 years ago

Can you make a pull request?

On 05/16/2013 04:09 PM, Simen Svale Skogsrud wrote:

A mention in the readme would be nice, but mainly I think attribution has been lost from the source files. Something like "Originally from Grbl (github.com/grbl/grbl)" somewhere in the comment blocks on top of the .c and .h files is plenty good.

— Reply to this email directly or view it on GitHub https://github.com/kliment/4pi-firmware/issues/15#issuecomment-18003252.

simen commented 11 years ago

Sure, why not.