search

kliment / 4pi-firmware

18 stars 21 forks source link

Old uart #2

Closed bilsef closed 11 years ago

bilsef commented 11 years ago

Added newlines to usb_printf statements in com_interpreter.c so temperature monitor will work in pronterface.

midopple commented 11 years ago

Hi bilsef,

The normal way is on the end from get_command() called the function ClearToSend()

This function send OK and the newline. At the moment there is a bug when usb_printf is called twice then the second string is not send.

void ClearToSend() { previous_millis_cmd = timestamp; usb_printf("ok\r\n"); }

kliment commented 11 years ago

Yes, once that bug is fixed we can remove the explicit newlines.

On 10/05/2012 08:22 AM, midopple wrote:

Hi bilsef,

The normal way is on the end from get_command() called the function ClearToSend()

This function send OK and the newline. At the moment there is a bug when usb_printf is called twice then the second string is not send.

void ClearToSend() { previous_millis_cmd = timestamp; usb_printf("ok\r\n"); }

— Reply to this email directly or view it on GitHub https://github.com/kliment/4pi-firmware/pull/2#issuecomment-9166599.

bilsef commented 11 years ago

Hi midopple,

Is there anything I could help you with?

midopple commented 11 years ago

Hi bilsef

there are some points like

i'am also at IRC freenode.

bilsef commented 11 years ago

middople,

Take a look at my motor_settings branch. I've implemented M350 (uSteps), M906 (mA current), and M907 (raw current). Let me know if you want me to change anything. If it's good, I'll merge it back to master.

midopple commented 11 years ago

Hi bilsef,

The code looks good, you can merge it back to master