search

kliment / Printrun

Pronterface, Pronsole, and Printcore - Pure Python 3d printing host software
GNU General Public License v3.0
2.38k stars 996 forks source link

Create pronterface.mo #1247

Closed Avag-Sayan closed 2 years ago

rockstorm101 commented 2 years ago

It is my understanding that .mo files are machine-dependant and therefore should not really be part of the source code [1]. They should be generated at build-time for each specific architecture. I am aware .mo files are (wrongly) stored for other languages. On this basis I would reject this PR along with #1246. I would even go as far as deleting all the existing .mo files for other languages. @kliment, @hroncok thoughts?

kliment commented 2 years ago

@rockstorm101 agreed, we should not have these in the repo, but generate as necessary

Avag-Sayan commented 2 years ago

In that case, pls remove from other lang folders.

On Sun, Mar 13, 2022, 5:34 PM kliment @.***> wrote:

@rockstorm101 https://github.com/rockstorm101 agreed, we should not have these in the repo, but generate as necessary

— Reply to this email directly, view it on GitHub https://github.com/kliment/Printrun/pull/1247#issuecomment-1066103587, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO6VOLD6LDNCKMXBY3U4WMTU7XVFTANCNFSM5PPA6LQQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

kliment commented 2 years ago

Removed all other .mo files in 741db3c1