search

kliment / Printrun

Pronterface, Pronsole, and Printcore - Pure Python 3d printing host software
GNU General Public License v3.0
2.36k stars 997 forks source link

Fix TypeError when adjusting speed, flow rate #1260

Closed volconst closed 2 years ago

volconst commented 2 years ago

Fixes #1258

kliment commented 2 years ago

Can you rebase this and 1259 to incorporate the comma fix?

volconst commented 2 years ago

Can I rebase using the web UI? In the other PR the merge of kliment/master to volconst is visible in kliment/master history. We want to rebase so no merge commit is visible in history, right? What if I delete this PR and create new? Won't this run the checks on the latest master without need of merge nor rebase?

kliment commented 2 years ago

I think you can rebase on your own local branch and then push. I don't think it's a problem if there's a merge commit, so feel free to do a pull and push instead if that's easier for you.

volconst commented 2 years ago

@kliment Can you delete this PR? I am not at the local branch now and also unsure about changing history of published branches with rebase.

volconst commented 2 years ago

Sorry, I had just to close it without merging to be able to recreate it