search

kliment / Printrun

Pronterface, Pronsole, and Printcore - Pure Python 3d printing host software
GNU General Public License v3.0
2.36k stars 997 forks source link

add some baud rates #1267

Closed prchal closed 1 year ago

prchal commented 2 years ago

Add some more fast baud rates.

rockstorm101 commented 1 year ago

Hi @prchal, I know you proposed this a long time ago, sorry about that. I don't see those rates being "standard" baud rates? At least not for 3D printers? What is your use case such that do need these rates? It would appear 460,800 or 576,000 and 921,600 are more common than exactly 500,000 and 1,000,000?

DivingDuck commented 1 year ago

I also do not like this very well as baud rate should follow 2n bit scheme for summarized bits, but unfortunately the Marlin folks broke with this kind of conventions ... https://github.com/MarlinFirmware/Marlin/blob/bugfix-2.1.x/Marlin/Configuration.h#L112

prchal commented 1 year ago

Because AVR can't generate such high 2^n bauds from 16MHz clock.

On 27. 03. 23 13:03, DivingDuck wrote:

I also do not like this very well as baud rate should follow 2^n bit scheme for summarized bits, but unfortunately the Marlin folks broke with this kind of conventions ... https://github.com/MarlinFirmware/Marlin/blob/bugfix-2.1.x/Marlin/Configuration.h#L112 https://github.com/MarlinFirmware/Marlin/blob/bugfix-2.1.x/Marlin/Configuration.h#L112

kliment commented 1 year ago

I agree with @prchal here - some firmwares use these baud rates for technical reasons, and whether we like it or not it's a reality and something some users need.

rockstorm101 commented 1 year ago

the Marlin folks broke with this kind of conventions ... https://github.com/MarlinFirmware/Marlin/blob/bugfix-2.1.x/Marlin/Configuration.h#L112

Oh, well spotted. Merging then.