search

kliment / Printrun

Pronterface, Pronsole, and Printcore - Pure Python 3d printing host software
GNU General Public License v3.0
2.38k stars 996 forks source link

Look in imagefile and pixmap paths as created by pip #1285

Closed Poikilos closed 2 years ago

Poikilos commented 2 years ago

(Fix #1284 ). Also, use lookup_file in the imagefile function, and add related documentation (PEP8 documentation plus returns).

kliment commented 2 years ago

Is this ready for review or do you still plan to add more commits?

Poikilos commented 2 years ago

This is ready for review.

kliment commented 2 years ago

@DivingDuck @hroncok @a2k-hanlon @rockstorm101 @volconst any objections to this? I'm ready to merge it.

rockstorm101 commented 2 years ago

@DivingDuck @hroncok @a2k-hanlon @rockstorm101 @volconst any objections to this? I'm ready to merge it.

I'm happy with this PR. Thanks a lot @poikilos. Great thing you documented this.

volconst commented 2 years ago

@DivingDuck @hroncok @a2k-hanlon @rockstorm101 @volconst any objections to this? I'm ready to merge it.

No objections

DivingDuck commented 2 years ago

Hi all,

Kliment, sorry for my late answer. I’m on a travel and have no possibility to take a look on this until end next week and there is a mostly tech free zone at our sailing trip 😊. Please don’t wait for me if the change is ok for you all. I will look on this when I’m back

Best regards, Armin

DivingDuck commented 2 years ago

Hi @kliment , sorry for the delay. I'm happy with this PR too. Well done documentation. Thanks a lot @poikilos.

kliment commented 2 years ago

I think we have enough consensus to merge this now. I'll do that. Thank you for your contribution @poikilos !