Closed Poikilos closed 2 years ago
Is this ready for review or do you still plan to add more commits?
This is ready for review.
@DivingDuck @hroncok @a2k-hanlon @rockstorm101 @volconst any objections to this? I'm ready to merge it.
@DivingDuck @hroncok @a2k-hanlon @rockstorm101 @volconst any objections to this? I'm ready to merge it.
I'm happy with this PR. Thanks a lot @poikilos. Great thing you documented this.
@DivingDuck @hroncok @a2k-hanlon @rockstorm101 @volconst any objections to this? I'm ready to merge it.
No objections
Hi all,
Kliment, sorry for my late answer. I’m on a travel and have no possibility to take a look on this until end next week and there is a mostly tech free zone at our sailing trip 😊. Please don’t wait for me if the change is ok for you all. I will look on this when I’m back
Best regards, Armin
Hi @kliment , sorry for the delay. I'm happy with this PR too. Well done documentation. Thanks a lot @poikilos.
I think we have enough consensus to merge this now. I'll do that. Thank you for your contribution @poikilos !
(Fix #1284 ). Also, use lookup_file in the imagefile function, and add related documentation (PEP8 documentation plus returns).