search

kliment / Printrun

Pronterface, Pronsole, and Printcore - Pure Python 3d printing host software
GNU General Public License v3.0
2.36k stars 995 forks source link

It should be possible to switch autocapitalization on and off. I think this is a due enhancement. #1297

Open FrHePo opened 1 year ago

rockstorm101 commented 1 year ago

Hi, would you please be able to provide an example of when this causes an issue?

FrHePo commented 1 year ago

https://github.com/prusa3d/Prusa-Firmware/issues/3891

wavexx commented 1 year ago

@rockstorm101 some commands expect data to pass though as-is. The dumbest command I can think of that expects data to pass though is setting an LCD message. In the prusa FW the memory read/write commands expect to contain lower-case hex characters. We can adjust the parser, but that would still break all old firmwares unexpectedly.

See https://github.com/kliment/Printrun/pull/1298 for a fix proposal which implements what is written here https://github.com/kliment/Printrun/issues/216#issuecomment-18603449