UXUI Polishing Part 1: Custom Button Dialog, Macro Editor, Options

[neofelis2X]

Hi there, I would like to propose some changes to the interface. Pronterface looks 'naturally grown' around some edges and I thought this is something where I can actually help. The aim is to make all dialogs, buttons, borders etc. look tidy and correct. For now, no behaviour changes and (almost) no backend changes. It has been compiled and tested on Windows and Mac. Some tests should be done on Linux systems. This should also fix #1328 I started with the following dialogs as a kind of test run:

Custom Button Dialog:

• Unified dialog button style
• Platform aware dialog buttons
• Borders etc
• Colour field now has a colour-picker
• Existing macros can be chosen from a list

Options Dialog:

• Unified dialog button style
• Platform aware dialog buttons
• Changed the proportion to make it a bit more compact
• Therefore the 'Colours' page is now scrolling

New Macro Dialog:

• Unified dialog button style
• Plaform aware dialog buttons
• Borders etc

Macro Editor:

• Unified dialog button style
• Platform aware dialog buttons
• Borders etc
• Added find&replace dialog to the 'Find' button and changed the logic a bit
• Defined MinSize

Feedback is of course very welcome. Example old

Example new

[rockstorm101]

Hi @neofelis2X, this is awesome! Thanks a lot.

Looks great. I've tested it on Linux. So far it works with no issues and it definitely looks better now.

I'll give the others more time to have a look but, a priori, I'd be happy to merge this. I assume you plan to rework the rest of the UI in the same way? Would you be happy to keep pushing onto this PR and merge at the end? Or what workflow do you propose?

In case you wonder, this is how it looks on my Debian machine:

[DivingDuck]

@neofelis2X, Very nice, I like this too. I've tested it with Windows 10 and don't recognize any problems so fare.

[kliment]

I also really like this. Thank you, @neofelis2X, for giving this project some love. My personal opinion is there's no harm in merging this as is even if more is coming - earlier merges avoid future merge conflicts.

[kliment]

@rockstorm101 does this PR fix #1328 for you?

[rockstorm101]

@rockstorm101 does this PR fix #1328 for you?

Yes, it does fix #1328

My personal opinion is there's no harm in merging this as is even if more is coming - earlier merges avoid future merge conflicts.

Good point. I'd give @neofelis2X a day in case they want to add/tweak anything else and then merge.

[neofelis2X]

I'm really glad you like it. Since you didn't see any problems I have nothing to add. I would agree that smaller merges are probably saver than all at once.

I assume you plan to rework the rest of the UI in the same way?

Yes, I will be happy to continue with the rest of the UI and pack it into reasonable PRs.

In case you wonder, this is how it looks on my Debian machine:

That's pretty good! Still funny how every platform has their own little differences.