search

kliment / Printrun

Pronterface, Pronsole, and Printcore - Pure Python 3d printing host software
GNU General Public License v3.0
2.36k stars 995 forks source link

Exchange of module pyreadline with pyreadline3 in requirements.txt #1332

Closed DivingDuck closed 1 year ago

DivingDuck commented 1 year ago

The module pyreadline seams to have no maintenance. By reviewing our latest latest build log I recognize a note in https://github.com/kliment/Printrun/actions/runs/4542190897/jobs/8005293012, line 107:

DEPRECATION: pyreadline is being installed using the legacy 'setup.py install' method, because it does not have a 'pyproject.toml' and the 'wheel' package is not installed. pip 23.1 will enforce this behaviour change. A possible replacement is to enable the '--use-pep517' option. Discussion can be found at https://github.com/pypa/pip/issues/8559

There exists a new fork called pyreadline3 that seems to be maintained and solved some of the problems the original module had and solve as well the deprecation note.

Reference

pyreadline: https://github.com/pyreadline/pyreadline/issues/76

pyreadline3: https://github.com/pyreadline3/pyreadline3

I integrated the new module in my repository for a couple of live prints and there was no problems so fare. So my suggestion is to switch to the new module.

Related to Windows build only

Please let me know what you are think about this @kliment, @rockstorm101

rockstorm101 commented 1 year ago

Hi @DivingDuck, did you run your tests on pronterface or on pronsole? I would say the readline module is more critical on the latter, so a successful run on pronsole would indicate whether they are truly interchangeable?

DivingDuck commented 1 year ago

Hi @rockstorm101, good point. I test it only on pronterface. I just start a needed little test print on pronsole and run monitor too.

DivingDuck commented 1 year ago

The print runs fine with pronsole and activated monitor too. Guess, I can send an update later this evening.