Closed rockstorm101 closed 1 year ago
Thinking out loud here, should we output a warning if no readline module was available?
I will test your change. I need to download your changed file and build a new binary. I will come back soon. I need a short break for an half hour. :)
For the question I don't think that it is needed as one who run it from source need to build the virtual environment and should use requirements.txt where we have it listed. It is also integrated for those who use the release_windows.bat for building the binary files (I include building pronsole).
While you are just checking pronsole, is there a quick solution possible to prevent loading button definitions in general? Maybe you have a good idea. I got a lot of messages like "*** Unknown syntax: button 45 "Extruder FastExtr+775" /c "#ED353E" G91 G1 E775.0 F4000"
as I have a lot of defined buttons.
I will come back soon. I need a short break for an half hour.
Absolutely, no worries. As with every other voluntary project like this one. Nothing is really urgent. So take your time.
While you are just checking pronsole, is there a quick solution possible to prevent loading button definitions in general? Maybe you have a good idea. I got a lot of messages like
"*** Unknown syntax: button 45 "Extruder FastExtr+775" /c "#ED353E" G91 G1 E775.0 F4000"
as I have a lot of defined buttons.
I'll have a look. Sounds like we should open an new issue to track this?
The test with Pronsole was successfully done. Test with pyreadline3 as well.
I will open a new issue for the unknown syntax.
@rockstorm101, I forgot to mention I open a issue for the unknown syntax issue: #1336
Reviewing issue #1332 made me realize we could clean up the importing of the readline module a bit. Let me know if I got it completely wrong. A quick test on my terminal showed no noticeable change in pronsole's behavior.
Goals:
@DivingDuck, please test on Windows and let us know if it breaks anything.