kliment / Printrun

Pronterface, Pronsole, and Printcore - Pure Python 3d printing host software
GNU General Public License v3.0
2.35k stars 995 forks source link

UXUI Polishing Part 2: Platers, G-Code Viewers, ProjectLayer and SpoolManager #1347

Closed neofelis2X closed 1 year ago

neofelis2X commented 1 year ago

Good Evening. It took a little longer than expected, I had to dig a bit deeper for some things. With this PR I continue to refine the ui of Pronterface. Example Plater: 230419_plater Example Spool Manager: 230419_spoolmanager

This was tested on MacOS and Windows, just like last time. I used real files and tried to test all situations I could think of. Here's a non-exhaustive list of changes, but it's probably better to look at the tools directly:

STL and G-Code Plater

Excluder + G-Code Viewer:

ProjectLayer Control

SpoolManager

I hope you like the changes. If so, I have plenty of ideas for further improvements.

neofelis2X commented 1 year ago

Wow, thanks for the thorough review. Some very good points you made. At the moment I do not have much time to spare, but I will add the changes in the next two weeks.

neofelis2X commented 1 year ago

Hi Rockstorm, great that you already looked at it. I will add the changes and check if everything is fine on windows.

One question: Am I seeing this correctly that every file that contains string-translations _( ) need to include this line: install_locale('pronterface') ?

DivingDuck commented 1 year ago

One question: Am I seeing this correctly that every file that contains string-translations _( ) need to include this line: install_locale('pronterface') ?

Both is correct.

rockstorm101 commented 1 year ago

Thanks a lot for your time, effort and patience. Great contribution.