search

kliment / Printrun

Pronterface, Pronsole, and Printcore - Pure Python 3d printing host software
GNU General Public License v3.0
2.35k stars 995 forks source link

Deprecation of disutils module #1357

Closed rockstorm101 closed 11 months ago

rockstorm101 commented 1 year ago

As per PEP 632 the distutils module is now officially deprecated and will be removed in Python 3.12. As far as I can see we only import distutils on the setup_win.py file. Do we even use this file at the moment? CC @DivingDuck

DivingDuck commented 11 months ago

Hi @rockstorm101,

I had totally overseen this issue. Sorry. We don't use setup_win.py file. Guess, this was a relic from from the time where Pronterface was build with python 2.7. This file can go in retirement :).

For windows builds we use the file setup.py too. Looking on that file I recognize there should be some adjustments made as well (e.g. supported Python versions: 3.6 isn't supported for actual wxPython, add py 3.9 and 3.10).

Best regards, DD

rockstorm101 commented 11 months ago

Thanks I'll proceed with the "retiring" then :P

Looking on that file I recognize there should be some adjustments made as well (e.g. supported Python versions: 3.6 isn't supported for actual wxPython, add py 3.9 and 3.10).

Good catch. I'll do that as well.